Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to change widgetset compilation style for superdevmode in command line #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wbadam
Copy link

@wbadam wbadam commented Aug 4, 2017

Resolves #103


This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2017

CLA assistant check
All committers have signed the CLA.

@Artur-
Copy link
Member

Artur- commented Aug 8, 2017

How does this differ from using -Dgwt.style?

@wbadam
Copy link
Author

wbadam commented Aug 8, 2017

It doesn't differ, the style parameter currently isn't passed further to the Codeserver in vaadin-maven-plugin, i.e. -Dgwt.style has no effect.

The same is implemented in this commit in gwt-maven-plugin: gwt-maven-plugin/gwt-maven-plugin@5eb7189 but was never introduced here.

@Artur-
Copy link
Member

Artur- commented Aug 9, 2017

I see, so it's missing a "superdevmode" keyword from the summary


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@wbadam wbadam changed the title Add possibility to change widgetset compilation style from command line Add possibility to change widgetset compilation style for superdevmode in command line Aug 9, 2017
@wbadam
Copy link
Author

wbadam commented Aug 9, 2017

Yes, sorry, the ticket I opened (#103) does have the keyword but forgot to mention it in the PR


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@hesara
Copy link
Contributor

hesara commented Aug 29, 2017

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


src/main/java/org/codehaus/mojo/gwt/shell/AbstractGwtShellMojo.java, line 92 at r1 (raw file):

     */
    @Parameter(defaultValue = "OBF", property = "gwt.style")
    protected String style;

Why make this protected instead of simply using getStyle() that also CompileMojo uses?


Comments from Reviewable

@wbadam
Copy link
Author

wbadam commented Aug 30, 2017

Review status: all files reviewed at latest revision, 1 unresolved discussion.


src/main/java/org/codehaus/mojo/gwt/shell/AbstractGwtShellMojo.java, line 92 at r1 (raw file):

Previously, hesara (Henri Sara) wrote…

Why make this protected instead of simply using getStyle() that also CompileMojo uses?

Could do that as well if you prefer, I copied the changes from gwt-maven-plugin https://github.com/gwt-maven-plugin/gwt-maven-plugin/blob/master/src/main/java/org/codehaus/mojo/gwt/shell/AbstractGwtShellMojo.java#L80


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to change widgetset compilation style for superdevmode in command line
4 participants