Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failed to start timer due to controller isn't ready #334

Closed
wants to merge 1 commit into from
Closed

fix: failed to start timer due to controller isn't ready #334

wants to merge 1 commit into from

Conversation

hwjiangkai
Copy link
Contributor

What problem does this PR solve?

failed to start timer due to controller isn't ready

Issue Number: close #288

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #334 (70ed328) into main (09f3748) will increase coverage by 0.12%.
The diff coverage is 61.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   62.72%   62.84%   +0.12%     
==========================================
  Files         133      143      +10     
  Lines       12128    13125     +997     
==========================================
+ Hits         7607     8249     +642     
- Misses       3977     4293     +316     
- Partials      544      583      +39
Impacted Files Coverage Δ
internal/primitive/vanus/id.go 19.84% <0.00%> (-0.49%) ⬇️
internal/raft/log/wal.go 100.00% <ø> (ø)
internal/store/block/raft/appender.go 0.00% <0.00%> (ø)
internal/store/block/raft/snapshot.go 0.00% <0.00%> (ø)
internal/store/block/raft/transport.go 0.00% <0.00%> (ø)
internal/store/io/file_linux.go 0.00% <0.00%> (ø)
internal/store/segment/server.go 13.32% <0.00%> (-0.11%) ⬇️
internal/store/vsb/block.go 46.34% <0.00%> (ø)
internal/store/vsb/block_seek.go 0.00% <0.00%> (ø)
internal/store/vsb/engine_open.go 3.44% <0.00%> (-0.13%) ⬇️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8236094...70ed328. Read the comment docs.

@wenfengwang
Copy link
Contributor

duplicated with #338

@hwjiangkai hwjiangkai deleted the fixctrlpanic branch December 14, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifplusor ifplusor Awaiting requested review from ifplusor ifplusor is a code owner

@wenfengwang wenfengwang Awaiting requested review from wenfengwang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed to start timer due to controller isn't ready
2 participants
@hwjiangkai @wenfengwang