feat(function): support md5 #5846
Conversation
|
|
|
Thank you for your contribution. The automated lint test has failed. You can click on this link or check the automated test results below to see where the issue is and fix it. Once fixed, you can commit the changes. |
CMakeLists.txt
Outdated
| @@ -30,6 +30,8 @@ option(ENABLE_PACKAGE_TAR "Enable package artifacts to tar." OFF) | |||
| option(ENABLE_CREATE_GIT_HOOKS "Enable create git hooks." ON) | |||
| option(ENABLE_INCLUDE_WHAT_YOU_USE "Enable include-what-you-use find nouse include files" OFF) | |||
|
|
|||
| SET(CMAKE_EXPORT_COMPILE_COMMANDS TRUE) | |||
There was a problem hiding this comment.
This CMAKE_EXPORT_COMPILE_COMMANDS option could be specified in cmake configuration step and need not to always turn it on. please cleanup it.
There was a problem hiding this comment.
please let the CI run.
There was a problem hiding this comment.
@fansehep hi, according to yixinglu's response, you can simply remove the added CMAKE_EXPORT_COMPILE_COMMANDS configuration statement. Currently, it is set to true, but as per yixinglu's suggestion, it is already configurable elsewhere, so there is no need to hardcode it here.
There was a problem hiding this comment.
thanks for your reminders, but from the CI compile output, the mold linker link error :(
There was a problem hiding this comment.
Nebula CI sometimes needs to run a few more times to pass. I will rerun it a few more times. Wait for my good news 🥺.
There was a problem hiding this comment.
thanks for your reminders, but from the CI compile output, the mold linker link error :(
Perhaps you should add some link dependencies, as commented in this issue. #5840
There was a problem hiding this comment.
@fansehep To fix the failure of CI, u'd better to check where the target $<TARGET_OBJECTS:function_manager_obj> is used in the whole code base, and add the the ${PROXYGEN_LIBRARIES} dependency for there.
There was a problem hiding this comment.
@fansehep CI has been fixed, shall we go on?
Signed-off-by: alexsehep <[email protected]>
Signed-off-by: alexsehep <[email protected]>
Signed-off-by: alexsehep <[email protected]>
* feat(function): support md5 (cherry picked from commit 84bb690) * format code Signed-off-by: alexsehep <[email protected]> (cherry picked from commit d2b17d4) * clean cmake option Signed-off-by: alexsehep <[email protected]> (cherry picked from commit 993bea6) * fix cmake Signed-off-by: alexsehep <[email protected]> (cherry picked from commit e607095) * fix cmake error in #5846 --------- Co-authored-by: alexsehep <[email protected]>
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: