Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-vue): default value for compile time flags #495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(plugin-vue): default value for compile time flags #495

wants to merge 1 commit into from
+28 −12

Conversation

edison1105
Copy link
Member

Description

close #480
refix #438
According to the docs https://vuejs.org/api/compile-time-flags.html#rollup, their values are strings, and converting 'false' to a boolean will result in true.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 24, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@vitejs/plugin-vue@495

npm i https://pkg.pr.new/@vitejs/plugin-vue-jsx@495

commit: a8e3183

@edison1105 edison1105 mentioned this pull request Dec 24, 2024
Open
9 tasks
@edison1105 edison1105 requested a review from sxzz December 24, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@btea btea btea approved these changes

@sxzz sxzz Awaiting requested review from sxzz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin is transforming string "false" options in define to true
3 participants
@edison1105 @btea @sapphi-red