Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use href carry no-inline query #491

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

btea
Copy link
Contributor

@btea btea commented Dec 16, 2024

Description

fix #490

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

pkg-pr-new bot commented Dec 16, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@vitejs/plugin-vue@491
npm i https://pkg.pr.new/@vitejs/plugin-vue-jsx@491

commit: e7345e2

@sapphi-red
Copy link
Member

I think instead of adding ?no-inline automatically, we need to tell @vue/compiler-sfc not to strip the queries and hashes (not sure if @vue/compiler-sfc is doing that). Otherwise, <img src="./foo.svg?inline"> or <img src="./foo.png?no-inline"> won't work as users expect.

@btea
Copy link
Contributor Author

btea commented Dec 17, 2024

No relevant configuration is found.

@btea btea marked this pull request as draft December 17, 2024 13:34
@btea
Copy link
Contributor Author

btea commented Dec 20, 2024

I haven't been able to find the relevant configuration.

Currently, it will only add ?no-inline to the href attribute of the use tag(it seems that only the use tag cannot directly load the data URIs link), which should not affect the processing of the img tag.

I haven't been able to find a better way, and would appreciate your suggestions.

@btea btea marked this pull request as ready for review December 20, 2024 13:07
@sapphi-red
Copy link
Member

Adding ?no-inline automatically for <use> in plugin-vue makes sense to me.

That said, if there isn't an option in @vue/compiler-sfc, I think that needs to be added to support other cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transformAssetUrls strips all queries and breaks SVG sprites
2 participants