Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go API to create HostRule CRD without TLS fails #1445

Open
andrew-su opened this issue May 31, 2024 · 0 comments
Open

Go API to create HostRule CRD without TLS fails #1445

andrew-su opened this issue May 31, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@andrew-su
Copy link
Member

andrew-su commented May 31, 2024

Describe the bug

When creating a HostRule resource by consuming AKO as a Go library, the TLS field is required. However the CRD identifies it as optional.

Reproduction steps

  1. Create a HostRule resource which does not explicitly define a TLS section:
desired := &aviv1beta1.HostRule{
	ObjectMeta: metav1.ObjectMeta{
		Name: "app1",
		Labels: map[string]string{
			"app": "gslb",
		},
	},
	Spec: aviv1beta1.HostRuleSpec{
		VirtualHost: aviv1beta1.HostRuleVirtualHost{
			FqdnType:          aviv1beta1.Exact,
			Fqdn:              "app.default.example.com",
			EnableVirtualHost: ptr.To(true),
			Gslb: aviv1beta1.HostRuleGSLB{
				Fqdn: "app.example.com",
			},
		},
	},
}
  1. Apply it using the Go client:
_, err := akoclient.AkoV1beta1().HostRules("my-namespace").Create(ctx, desired, metav1.CreateOptions{})
  1. Client reports that TLS Certificate name can not be empty string.

Expected behavior

The resource is applied successfully.

Additional context

No response

@andrew-su andrew-su added the bug Something isn't working label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant