Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dual-stack support for NPL and NodePort #1536

Closed
wants to merge 1 commit into from

Conversation

Qwiko
Copy link

@Qwiko Qwiko commented Sep 11, 2024

My attempt to resolve #1535.
Would like some input from the maintainers if this approach is a good one.
In PopulateServersForNPL there is some duplicate code now that could be tweaked further.
Also: I have not looked over PopulateServers in this PR but would like some input if this also needs to be tweaked to fully support dual-stack support.

@vmwclabot
Copy link
Member

@Qwiko, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@Dhivyaaj
Copy link

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

@akshayhavile
Copy link
Contributor

Can one of the admins verify this patch?

@vmwclabot
Copy link
Member

@Qwiko, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link
Member

@Qwiko, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

test reject

@vmwclabot
Copy link
Member

@Qwiko, VMware has approved your signed contributor license agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodePort mode does not fully support dual-stack networking
4 participants