Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

componentDidUpdate not transformed to Vue equivalent. #16

Open
nlieb opened this issue Jul 31, 2017 · 3 comments
Open

componentDidUpdate not transformed to Vue equivalent. #16

nlieb opened this issue Jul 31, 2017 · 3 comments

Comments

@nlieb
Copy link

nlieb commented Jul 31, 2017

As in the title, componentDidUpdate is not transformed to a Vue equivalent.

@armano2
Copy link

armano2 commented Jul 31, 2017

can you provide example?

and i think this is equivalent of updated from vue

https://vuejs.org/v2/guide/instance.html#Instance-Lifecycle-Hooks
lifecycle

@nlieb
Copy link
Author

nlieb commented Jul 31, 2017

It is possibly closer to beforeUpdate since it is called even when the virtual DOM is not changed (but the render function did get called via a props or state change). There are also additional parameters which would have to be modelled manually since I don't believe Vue offers a similar API for prevProps and prevState. They are described here: https://facebook.github.io/react/docs/react-component.html#componentdidupdate

In what form would you like the example to be? Currently the transform treats componentDidUpdate
like an un-special function and simply plops the method into the 'methods' Vue property.

@armano2
Copy link

armano2 commented Jul 31, 2017

idk, they will just need a bit more data to easier implement this (more you explain == less work they have)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants