Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): the directive's modifiers should be optional #12605

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

noootwo
Copy link
Contributor

@noootwo noootwo commented Dec 24, 2024

fix #12604

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.9 kB 34.2 kB
vue.global.prod.js 158 kB 57.8 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.3 kB 18.2 kB 16.6 kB
createApp 54.2 kB 21.1 kB 19.3 kB
createSSRApp 58.4 kB 22.9 kB 20.8 kB
defineCustomElement 59.1 kB 22.7 kB 20.7 kB
overall 68.3 kB 26.3 kB 23.9 kB

Copy link

pkg-pr-new bot commented Dec 24, 2024

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12605

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12605

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12605

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12605

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12605

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12605

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12605

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12605

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12605

vue

npm i https://pkg.pr.new/vue@12605

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12605

commit: 15809fd

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: types labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged. scope: types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directive type definition has wrong "modifiers" definition
2 participants