Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epub:prefix should not be allowed on embedded svg #1535

Open
mattgarrish opened this issue Jul 21, 2023 · 1 comment
Open

epub:prefix should not be allowed on embedded svg #1535

mattgarrish opened this issue Jul 21, 2023 · 1 comment
Assignees
@rdeltour
Labels
status: has PR The issue is being processed in a pull request type: false-negative This issue is about invalid content being incorrectly accepted
Milestone
Next maintenance ...

Comments

@mattgarrish
Copy link
Member

While fixing w3c/epub-specs#2555, I noticed epubcheck doesn't report an epub:prefix attribute on an svg element when embedded directly in an html document. The following should be illegal:

<html ... epub:prefix="foo: https://bar.com">
   ...
   <body>
      <svg ... epub:prefix="bar: https://foo.com">
        ...
      </svg>
   </body>
</html>

The requirement for this is in D.1.4:

Note that for embedded SVG, prefixes MUST be declared on the [html] root html element.

(But this is hardly a priority fix!)
@rdeltour rdeltour self-assigned this Aug 31, 2023
@rdeltour rdeltour added status: accepted Ready to be further processed type: false-negative This issue is about invalid content being incorrectly accepted labels Aug 31, 2023
@rdeltour rdeltour added this to the Next maintenance release milestone Aug 31, 2023
@rdeltour
Copy link
Member

Ah, good catch. I'm not too surprised, since this is checked by the schema (as far as I remember), and the SVG schema is shared by both standalone and embedded SVG.
It can probably be fixed by moving that attribute declaration to the integration schemas. I'll look into it when prepping the next milestone.

@rdeltour rdeltour added status: in progress The issue is being implemented by the development team and removed status: accepted Ready to be further processed labels Dec 22, 2024
rdeltour added a commit that referenced this issue Dec 23, 2024
@rdeltour
fix: disallow epub:prefix on embedded SVG
623f5ad 
Fix #1535
@rdeltour rdeltour added status: has PR The issue is being processed in a pull request and removed status: in progress The issue is being implemented by the development team labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdeltour rdeltour

Labels
status: has PR The issue is being processed in a pull request type: false-negative This issue is about invalid content being incorrectly accepted
Projects
None yet
Milestone
Next maintenance release
Development

No branches or pull requests
2 participants
@rdeltour @mattgarrish