Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The spec site style is corrupted #138

Closed
filip26 opened this issue Feb 26, 2024 · 3 comments
Closed

The spec site style is corrupted #138

filip26 opened this issue Feb 26, 2024 · 3 comments
Assignees
Labels
pr-exists A Pull Request exists to address this issue.

Comments

@filip26
Copy link

filip26 commented Feb 26, 2024

Please check https://w3c.github.io/vc-di-bbs/ ToC, Terminology, and algorithm style is corrupted. Thanks.

Context:
@davidlehn vc-di-bbs is including vc-data-integrity terms.html directly, which
has been removed 2 days ago.
https://github.com/w3c/vc-data-integrity/commits/main/
https://github.com/w3c/vc-di-bbs/blob/main/index.html#L306

@davidlehn
Copy link
Contributor

@msporny You were doing the vc-data-integrity changes. Looks like that early failure to load terms.html here might be causing some cascading errors in this spec rendering. If resources like terms.html and common.js were to be shared with other DI specs, will need to fix that up, and should probably leave comments there noting those are used cross-spec.

@msporny
Copy link
Member

msporny commented Feb 26, 2024

yes, aware of the issue... the problem is here: w3c/vc-di-ecdsa#57 (comment) ... I have to try things, then wait 6 hours to see if the problem was fixed... super annoying way to do spec editing work... this has to do w/ cross-references between specs, and the ReSpec folks suggesting that I update to the new approach (which is better, but which broke external references)... The BBS spec can be fixed by doing something like this for now: https://github.com/w3c/vc-di-ecdsa/blob/main/index.html#L141 and https://github.com/w3c/vc-di-ecdsa/blob/main/index.html#L245-L249 -- PRs welcome :)

@Wind4Greg Wind4Greg self-assigned this Mar 1, 2024
@Wind4Greg Wind4Greg added the pr-exists A Pull Request exists to address this issue. label Mar 1, 2024
@msporny
Copy link
Member

msporny commented Mar 3, 2024

Fixed in cfef8e3 and published here: https://www.w3.org/TR/2024/WD-vc-di-bbs-20240303/

Everything should be working again. Closing.

@msporny msporny closed this as completed Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-exists A Pull Request exists to address this issue.
Projects
None yet
Development

No branches or pull requests

4 participants