Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should tentative tests require links? #217

Open
gsnedders opened this issue Dec 23, 2024 · 0 comments
Open

Should tentative tests require links? #217

gsnedders opened this issue Dec 23, 2024 · 0 comments

Comments

@gsnedders
Copy link
Member

For background, see my prior comment on #215 (comment).

According to our docs:

It should be apparent in context why the test is tentative and what needs to be resolved to make it non-tentative.

I'd hope that tentative tests would include a link to a spec bug that needs to be resolved for the test to be non-tentative.

However:

% rg --glob '*tentative*' 'https?://((bugs\.webkit\.org|bugs\.chromium\.org|crbug\.com|issues\.chromium\.org)/|github\.com/.*/(issue|pull))' --files-without-match | wc -l
    2078

…shows we have a very large number of tentative tests which don't link anywhere (even a vendor bug tracker!).

This makes it hard to audit the status of tentative tests, and what should and should not still be tentative.

An obvious option here is to require tentative tests to have a link — though what to is a reasonable question — which might be worth considering?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant