-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File moves in wpt repo are not reflected #2267
Comments
Renames are done as part of https://github.com/web-platform-tests/wpt-metadata/blob/master/.github/workflows/update_wpt_manifest.yml, and at least some renaming is happening in #2266 |
OK, looks like there's a bug. https://github.com/web-platform-tests/wpt-metadata/runs/4506562611?check_suite_focus=true is failing due to dir-style-03a.html not being in the manifest, and must not have detected the rename in web-platform-tests/wpt#31997 correctly. |
with #2302, all metadata should be moved accordingly. I still have to look into why update_wpt_manifest.yml failed to rename the tests. Thanks for reporting the issue! |
Should't be. For #2260, I deleted them manually and thought deletion didn't work properly in the GitHub actions. I should have circled back and dug into it. In general I screen the change manually myself |
This leaves oddities with Interop 2022; for example, see f9afd65 which dealt with /css/css-scroll-snap/scroll-snap-stop.html being renamed to /css/css-scroll-snap/scroll-snap-stop-001.html: this now means that earlier Interop 2022 runs (i.e., where the wpt.fyi data predates the rename) don't include the test, despite it having existed since 2019. |
Yes, we keep metadata in sync with WPT and the Interop 2022 scoring code doesn't follow renames in the past, so a renamed test will behave exactly like a new test. I don't have any (good) ideas for how to improve on this. |
See commits linked to web-platform-tests/wpt#8615
They should be reflected here.
The text was updated successfully, but these errors were encountered: