Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for removing notifications should not always run #484

Open
neremic opened this issue Jul 21, 2016 · 0 comments
Open

check for removing notifications should not always run #484

neremic opened this issue Jul 21, 2016 · 0 comments
Assignees
@neremic

Comments

@neremic
Copy link
Contributor

neremic commented Jul 21, 2016

Currently every 5 seconds there is a check running to remove "old" notifications even if there are no notifications at all. this should be changed so that the periodic check only starts to run if there are notifications and is stopped if there are no more notifications
@neremic neremic self-assigned this Jul 21, 2016
neremic pushed a commit that referenced this issue Jul 21, 2016
#484 check for notifications now only runs if there are notifications…
aa1f496 
… present
neremic pushed a commit that referenced this issue Jul 21, 2016
#484 due to high demand I removed the unneeded props variable
77c27d4
neremic pushed a commit that referenced this issue Jul 21, 2016
#484 less code dublication
5b125e3
neremic pushed a commit that referenced this issue Jul 21, 2016
#484 removed code dublication
72b523c
neremic added a commit that referenced this issue Jul 21, 2016
@neremic
Merge pull request #485 from zalando-stups/484-check-for-removing-not…
9bbe1c5 
…ifications-should-not-always-run

#484 check for notifications only if there are notification are present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neremic neremic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@neremic