-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft support not enabled by default #638
Comments
The draft is not enabled in the latest release yet. I plan to enable it in the upcoming release. The readme shows the dev status. |
@aminya are the cli / .npmrc --zmq-draft and --build-from-source flags expected to work? I'm not convinced the zmq lib is being rebuilt when I'm using them, and when trying to use draft features (RADIO/DISH), I get
If this isn't expected, I can create a new issue and include more details (but succinctly: arm osx 13, node 20) |
Building from the source first checks for the binaries. So, it doesn't build from the source in reality if the binaries already exist. You can work around this by removing the prebuilds folder. We should fix this though. |
I have migrated the build to CMake/vcpkg. Now you can enable the |
Describe the bug A clear and concise description of what the bug is.
ZMQ Draft support is not enabled by default in builds, despite the suggestion in the README
Quick ref:
zeromq.js/.github/workflows/CI.yml
Line 64 in f9ee2a3
zeromq.js/binding.gyp
Line 4 in f9ee2a3
Is the README technically incorrect or should the build scripts & config be updated? Can submit a PR to correct either way.
The text was updated successfully, but these errors were encountered: