Add config option on whether to enable Jekyll output. #17
Conversation
| @@ -141,7 +146,8 @@ def write_stream_index(streams): | |||
| sanitize_stream(s, streams[s]['id']), | |||
| num_topics, | |||
| '' if num_topics == 1 else 's')) | |||
| outfile.write('\n{% include ' + str(last_updated_file) + ' %}') | |||
| if jekyll_output: | |||
| outfile.write('\n{% include ' + str(last_updated_file) + ' %}') | |||
There was a problem hiding this comment.
@Mark-Simulacrum what you want is for the {%include ... %} directive to be removed, right? Do you still want the last_updated_file info be in the output somehow?
| write_topic_body(messages, stream_name, stream['id'], topic_name, o) | ||
| o.write('\n{% endraw %}\n') | ||
| o.write('\n{% include ' + str(last_updated_file) + ' %}') | ||
| if jekyll_output: |
There was a problem hiding this comment.
@Mark-Simulacrum is this what you wanted?
There was a problem hiding this comment.
I would prefer that in non-Jekyll mode we literally include the contents instead of via an include statement. That does mean that all of the files will change on each run, but that's true if you render through jekyll to a static site anyway.
|
I am gonna close this PR, since #19 is on the way to address the things that are fixed here. First, #19 fixes one of the biggest complaints from #12, which is that we had the "include" directive, which was pretty silly in the first place for our use case. (It was literally just importing a one-line date that was easier programmatically to just write to the files directly.) I'm also doing some structural changes to the overall code that are probably gonna mess with the changes here, but I can crib off of this PR once that settles. I'm gonna keep #12 open, since we also want to deal with other non-Jekyll scenarios. |
This fixes #12.