Move resizing out of Window.focus, and into Window.init_for_scene #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you mean by "resyncing" in "resyncing the viewport" here? |
|
The symptom is that the scene appears off center in the Window. I'm not 100% sure what's going on, if I was there would probably be a more principled fix than simply calling "resize" arbitrarily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat confusingly, the window viewport can get offset on initialization, and on reload, in a way that simply resizing the window (even to its current size) fixes.
Previously I had added this to Window.focus, while also calling focus in Window.init_for_scene. Better is to not necessarily focus on init, and to put the sync line in there directly. This should partially address the annoyance in #2271