Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Suppress warnings #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Suppress warnings #128

wants to merge 1 commit into from

Conversation

aki77
Copy link

@aki77 aki77 commented Jun 23, 2017

Related issue: #117

@Arcanemagus
Copy link
Member

If #117 is what you are attempting to "fix" here, I'm definitely against this way of fixing it. #117 is due to users not configuring their environment properly (and the extreme fragility of the parser used by haml-lint).

If you want to write a way of filtering just those messages, hidden behind an option that defaults to disabled then I would be okay with that as users should know their environment is broken instead of having it hidden by default as this would do.

@aki77
Copy link
Author

aki77 commented Jun 26, 2017

Users environment is not the cause.
Please refer to the following link.

sds/haml-lint#214

@Arcanemagus
Copy link
Member

That's just a case of the other part of that: the extreme fragility of the parse in use. In either case what you have proposed here as a "solution" would hide all errors, including fatal messages. Any solution that deals with these messages will need to filter them explicitly and show anything not filtered to the user.

@martinzuern
Copy link

martinzuern commented Jul 22, 2017

Why not having a field that allows the user to set throwOnStderr which could still default to true?
I'm using Ruby 2.3.4 and there is no parser release available for at the moment, so there is no way to 'configure the environment properly'.

@Arcanemagus
Copy link
Member

@jschroeder9000 Care to weigh in here? The haml-lint community seems to disagree with what most other tools would do, so I don't think I'm the right person to be making final decisions here.

@vzamanillo vzamanillo mentioned this pull request Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants