Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a cmake formatting tool in the CI #670

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Add a cmake formatting tool in the CI #670

merged 3 commits into from
Oct 30, 2024

Conversation

tpadioleau
Copy link
Member

@tpadioleau tpadioleau commented Oct 29, 2024 •
edited
Loading

  • set up the CI to check cmake format with gersemi
  • apply gersemi formatting

@tpadioleau tpadioleau self-assigned this Oct 29, 2024
@tpadioleau tpadioleau linked an issue Oct 29, 2024 that may be closed by this pull request
Equivalent of clang-format for cmake #41
Closed
@tpadioleau tpadioleau force-pushed the 41-equivalent-of-clang-format-for-cmake branch 3 times, most recently from 4affd90 to 149c639 Compare October 29, 2024 13:55
@tpadioleau tpadioleau force-pushed the 41-equivalent-of-clang-format-for-cmake branch from 7a71e9d to a5d2d87 Compare October 29, 2024 13:57
science-enthusiast
science-enthusiast approved these changes Oct 29, 2024
View reviewed changes
Copy link

@science-enthusiast science-enthusiast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit regarding CI looks reasonable.
The changes to the cmake file seem to follow the two formatting rules: line size 100 and indentation 4. Anyway, the cmake-format check has passed along with the other checks.

cedricchevalier19
cedricchevalier19 previously approved these changes Oct 29, 2024
View reviewed changes
.github/workflows/tests.yml Outdated Show resolved Hide resolved
yasahi-hpc
yasahi-hpc previously requested changes Oct 29, 2024
View reviewed changes
Copy link
Member

@yasahi-hpc yasahi-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess CI can be simplified.
Other modifications are good

.github/workflows/tests.yml Outdated Show resolved Hide resolved
@tpadioleau tpadioleau force-pushed the 41-equivalent-of-clang-format-for-cmake branch from 74ba323 to b073223 Compare October 30, 2024 09:34
cedricchevalier19
cedricchevalier19 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@cedricchevalier19 cedricchevalier19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpadioleau tpadioleau dismissed yasahi-hpc’s stale review October 30, 2024 10:04

From yasahi-hpc "Current CI is fine then"

@tpadioleau
Copy link
Member Author

@science-enthusiast @cedricchevalier19 @yasahi-hpc thank you I will merge

@tpadioleau tpadioleau merged commit 7b26395 into main Oct 30, 2024
57 checks passed
@tpadioleau tpadioleau deleted the 41-equivalent-of-clang-format-for-cmake branch October 30, 2024 14:51
@tpadioleau tpadioleau mentioned this pull request Nov 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasahi-hpc yasahi-hpc yasahi-hpc left review comments

@cedricchevalier19 cedricchevalier19 cedricchevalier19 approved these changes

@science-enthusiast science-enthusiast science-enthusiast approved these changes

Assignees

@tpadioleau tpadioleau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Equivalent of clang-format for cmake
4 participants
@tpadioleau @science-enthusiast @cedricchevalier19 @yasahi-hpc