-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedzy Loop Block #1045
base: development
Are you sure you want to change the base?
Feedzy Loop Block #1045
Conversation
* [wip] Import Conditions * fix: e2e test failing * fix: unit tests * test: adding phpunit tests * fix: e2e test failing * fix: backward compat * Update ConditionsControl.js * chore: add dummy conditions for upsell * chore: allow editing of conditions without saving in free * feat: add filters support to shortcode * chore: improve upsell * fix: display of regex strings as special chars * chore: fix eslint error * chore: fix broken code * fix: the mess with escape and unescaping
instead of magic tags cant we use block bindings api? @HardeepAsrani |
@selul We can but that will require us a lot more work. First, given that we haven't used it before, it will require some trial and error to figure out the best way. Second, I'm unsure it will work with the current approach that we have with doing server-side find/replace, but to create an actual query loop that can pass context. Finally, it has no UI for the user, so we will have to create some sort of UI to allow the user to bind elements. I like the direction the block is taking. I think we can start with this simple block, and if users really like this approach, we can improve it to work more like a Query Loop. |
Summary
Important: This PR includes Filters, so merge it after that has been merged.
This PR adds a new Feedzy Loop block, similar to MPG Loop Block, that allows users to create query loops out of their feeds.
To display the feed values, you need to use magic tags like
{{feedzy_title}}
, you can find a lost of all the available magic tags here: https://github.com/Codeinwp/feedzy-rss-feeds/blob/feat/block/includes/gutenberg/feedzy-rss-feeds-loop-block.php#L200For Feed Image, you can add an image block inside the loop and it will have this action button that makes it load the feed image.
If you click outside the block, it will preview the block.
Few notes:
Will affect visual aspect of the product
YES
Screenshots
Test instructions
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/777.