Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedzy Loop Block #1045

Open
wants to merge 8 commits into
base: development
Choose a base branch
from
Open

Feedzy Loop Block #1045

wants to merge 8 commits into from

Conversation

HardeepAsrani
Copy link
Member

@HardeepAsrani HardeepAsrani commented Dec 26, 2024

Summary

Important: This PR includes Filters, so merge it after that has been merged.

This PR adds a new Feedzy Loop block, similar to MPG Loop Block, that allows users to create query loops out of their feeds.

To display the feed values, you need to use magic tags like {{feedzy_title}}, you can find a lost of all the available magic tags here: https://github.com/Codeinwp/feedzy-rss-feeds/blob/feat/block/includes/gutenberg/feedzy-rss-feeds-loop-block.php#L200

For Feed Image, you can add an image block inside the loop and it will have this action button that makes it load the feed image.
Screenshot 2024-12-27 at 4 24 20 AM

If you click outside the block, it will preview the block.

Few notes:

  • I haven't removed the old block for now. We can give it some time to see how this block works and remove the old one onces we are sure this one can work just a well.

Will affect visual aspect of the product

YES

Screenshots

Screenshot 2024-12-27 at 4 20 25 AM Screenshot 2024-12-27 at 4 20 40 AM

Test instructions

  • Make sure the block works great with different feeds, including the Filter Conditions.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/777.

* [wip] Import Conditions

* fix: e2e test failing

* fix: unit tests

* test: adding phpunit tests

* fix: e2e test failing

* fix: backward compat

* Update ConditionsControl.js

* chore: add dummy conditions for upsell

* chore: allow editing of conditions without saving in free

* feat: add filters support to shortcode

* chore: improve upsell

* fix: display of regex strings as special chars

* chore: fix eslint error

* chore: fix broken code

* fix: the mess with escape and unescaping
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Dec 26, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Dec 26, 2024

Plugin build for 798fe7c is ready 🛎️!

@selul
Copy link
Contributor

selul commented Dec 27, 2024

instead of magic tags cant we use block bindings api? @HardeepAsrani

@HardeepAsrani
Copy link
Member Author

@selul We can but that will require us a lot more work. First, given that we haven't used it before, it will require some trial and error to figure out the best way. Second, I'm unsure it will work with the current approach that we have with doing server-side find/replace, but to create an actual query loop that can pass context. Finally, it has no UI for the user, so we will have to create some sort of UI to allow the user to bind elements.

I like the direction the block is taking. I think we can start with this simple block, and if users really like this approach, we can improve it to work more like a Query Loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants