Add macro to list currency id constants (list_assets) #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benluelo
requested review from
seunlanlege,
hussein-aitlahcen,
KaiserKarel and
vimukthi-git
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
PoisonPhang
previously approved these changes
Jun 10, 2022
dzmitry-lahoda
previously approved these changes
Jun 10, 2022
benluelo
dismissed stale reviews from dzmitry-lahoda and PoisonPhang
via
7ceeb90
benluelo
force-pushed
the
ben/currency-id-list-assets-macro
branch
from
2079b96 to
bd5b873
Compare
PoisonPhang
previously approved these changes
Jun 13, 2022
KaiserKarel
previously approved these changes
Jun 17, 2022
|
@benluelo can you rebase this? |
benluelo
force-pushed
the
ben/currency-id-list-assets-macro
branch
from
bd5b873 to
f70f34e
Compare
andor0
previously approved these changes
Jun 17, 2022
dzmitry-lahoda
previously approved these changes
Jun 17, 2022
vimukthi-git
previously approved these changes
Jun 17, 2022
benluelo
dismissed stale reviews from vimukthi-git, dzmitry-lahoda, and andor0
via
1416f79
|
Deployment failed with the following error: |
Codecov Report
@@ Coverage Diff @@
## main #1138 +/- ##
==========================================
+ Coverage 57.96% 57.99% +0.03%
==========================================
Files 317 317
Lines 39850 39825 -25
==========================================
- Hits 23098 23097 -1
+ Misses 16752 16728 -24
Continue to review full report at Codecov.
|
KaiserKarel
approved these changes
Jun 17, 2022
lilith-roth
approved these changes
Jun 17, 2022
andor0
approved these changes
Jun 17, 2022
vimukthi-git
approved these changes
Jun 17, 2022
dzmitry-lahoda
approved these changes
Jun 17, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed the list_assets function and the defined
CurrencyIdconsts were going out of sync periodically, so I added a simple macro to define thelist_assetsfunction.NOTE: parity-scale-codec-derive is broken as of 3.1.3: paritytech/parity-scale-codec#348, added a patch.