Decimal256 #1067
Merged
Decimal256 #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
webmaster128
reviewed
Sep 2, 2021
|
Alright, the two open changes:
Then 🚀 |
|
Rebased. |
webmaster128
reviewed
Sep 6, 2021
CHANGELOG.md
Outdated
| @@ -21,6 +21,7 @@ and this project adheres to | |||
| `Into<Uint128>` rather than `Into<u128>`. | |||
| - cosmwasm-crypto: Update dependency `k256` to ^0.9.6. | |||
| - cosmwasm-std: Add enum cases `Shl` to `OverflowOperation` (breaking; [#1071]). | |||
| - cosmwasm-std: `Decimal256` now has 18 decimal places. | |||
There was a problem hiding this comment.
I think we can drop this as Decimal256 is newly created in this PR
Co-authored-by: Simon Warta <[email protected]>
uint
commented
Sep 7, 2021
CHANGELOG.md
Outdated
| @@ -40,6 +41,7 @@ and this project adheres to | |||
| `Uint64`, `Uint128`, `Uint256`, and `Uint512`. | |||
| - cosmwasm-std: Exposed `Uint{64, 128, 256}::full_mul` for full multiplication | |||
| that cannot overflow. | |||
| - cosmwasm-std: Added the `Decimal256` type with 18 decimal places. | |||
There was a problem hiding this comment.
Ah, I guess this ended up in the wrong section after the rebase and got me confused. Let's fix this...
webmaster128
approved these changes
Sep 7, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whew. We've got our own
Decimal256.Addresses #1052. I'm not sure if there's any more work there except for getting this PR in. I'll review tomorrow.Closes #1052