[Crashtracker] Fix missing GetThreadDescription symbol #6357

gleocadie · 2024-11-26T14:28:47Z

Summary of changes

This should fix the issue

Reason for change

Crashtracker uses GetThreadDescription function from kernel32.dll (or kernelbase.dll). Which makes this function to be required for loading the Datadog.Profiler.Native.dll.

For some reason, the dynamic loader/linker is unable to find this function. To prevent this, we reuse what's in OpSysTools.

Implementation details

Use OpSysTools::GetThreadName and convert the WSTRING to std::string.

Test coverage

Other details

We need to checks that threads are correctly retrieved in crashtracker.

kevingosse

Thanks!

datadog-ddstaging · 2024-11-26T15:04:37Z

Datadog Report

Branch report: gleocadie/fix-gethread-description-missing
Commit report: f09ad5d
Test service: dd-trace-dotnet

✅ 0 Failed, 457196 Passed, 3239 Skipped, 21h 16m 26.59s Total Time

andrewlock · 2024-11-26T15:24:59Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6357) - mean (76ms)  : 72, 81
     .   : milestone, 76,
    master - mean (69ms)  : 67, 70
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6357) - mean (1,036ms)  : crit, 1010, 1062
     .   : crit, milestone, 1036,
    master - mean (975ms)  : 954, 996
     .   : milestone, 975,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6357) - mean (120ms)  : 114, 126
     .   : milestone, 120,
    master - mean (108ms)  : 105, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6357) - mean (728ms)  : crit, 710, 746
     .   : crit, milestone, 728,
    master - mean (679ms)  : 666, 691
     .   : milestone, 679,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6357) - mean (102ms)  : 96, 107
     .   : milestone, 102,
    master - mean (91ms)  : 88, 94
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6357) - mean (677ms)  : crit, 660, 694
     .   : crit, milestone, 677,
    master - mean (630ms)  : 615, 646
     .   : milestone, 630,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6357) - mean (190ms)  : 185, 195
     .   : milestone, 190,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6357) - mean (1,104ms)  : 1070, 1137
     .   : milestone, 1104,
    master - mean (1,094ms)  : 1064, 1124
     .   : milestone, 1094,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6357) - mean (276ms)  : 274, 279
     .   : milestone, 276,
    master - mean (277ms)  : 272, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6357) - mean (874ms)  : 848, 899
     .   : milestone, 874,
    master - mean (871ms)  : 837, 906
     .   : milestone, 871,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6357) - mean (267ms)  : 262, 271
     .   : milestone, 267,
    master - mean (266ms)  : 261, 271
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6357) - mean (855ms)  : 814, 895
     .   : milestone, 855,
    master - mean (851ms)  : 810, 893
     .   : milestone, 851,

chrisnas

LGTM

andrewlock · 2024-11-26T17:12:12Z

Benchmarks Report for tracer 🐌

Benchmarks for #6357 compared to master:

All benchmarks have the same speed
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.78μs	42.5ns	240ns	0.0153	0.00763	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	54.5ns	308ns	0.0198	0.00988	0	5.8 KB
master	`StartStopWithChild`	net472	16.2μs	36.4ns	141ns	1.04	0.305	0.104	6.21 KB
#6357	`StartStopWithChild`	net6.0	8.02μs	44.5ns	267ns	0.0157	0.00786	0	5.6 KB
#6357	`StartStopWithChild`	netcoreapp3.1	10μs	53.7ns	360ns	0.0147	0.0049	0	5.81 KB
#6357	`StartStopWithChild`	net472	16.2μs	55ns	213ns	1.03	0.294	0.098	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	484μs	202ns	729ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	662μs	256ns	992ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	854μs	501ns	1.87μs	0.428	3.3 KB
#6357	`WriteAndFlushEnrichedTraces`	net6.0	491μs	265ns	1.03μs	0	2.7 KB
#6357	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	676μs	591ns	2.21μs	0	2.7 KB
#6357	`WriteAndFlushEnrichedTraces`	net472	848μs	881ns	3.41μs	0.419	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	149μs	850ns	6.47μs	0.168	14.47 KB
master	`SendRequest`	netcoreapp3.1	163μs	881ns	5.71μs	0.165	17.27 KB
master	`SendRequest`	net472	0.00132ns	0.000695ns	0.0026ns	0	0 b
#6357	`SendRequest`	net6.0	153μs	889ns	7.8μs	0.145	14.47 KB
#6357	`SendRequest`	netcoreapp3.1	168μs	978ns	8.8μs	0.167	17.27 KB
#6357	`SendRequest`	net472	0.00144ns	0.000516ns	0.00193ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	558μs	2.02μs	7μs	0.573	0	0	41.62 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	678μs	3.49μs	17.1μs	0.338	0	0	41.82 KB
master	`WriteAndFlushEnrichedTraces`	net472	847μs	4.16μs	17.7μs	8.13	2.57	0.428	53.29 KB
#6357	`WriteAndFlushEnrichedTraces`	net6.0	570μs	2.93μs	13.7μs	0.556	0	0	41.64 KB
#6357	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	684μs	3.46μs	16.2μs	0.332	0	0	41.76 KB
#6357	`WriteAndFlushEnrichedTraces`	net472	834μs	3.26μs	12.6μs	8.22	2.47	0.411	53.3 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.23μs	0.817ns	2.94ns	0.0141	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.76μs	2.84ns	9.85ns	0.0138	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.16μs	1.99ns	7.71ns	0.157	0.00108	987 B
#6357	`ExecuteNonQuery`	net6.0	1.32μs	1.67ns	6.47ns	0.0139	0	1.02 KB
#6357	`ExecuteNonQuery`	netcoreapp3.1	1.74μs	1.2ns	4.5ns	0.0131	0	1.02 KB
#6357	`ExecuteNonQuery`	net472	2.03μs	1.69ns	6.53ns	0.156	0.00102	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.18μs	0.683ns	2.56ns	0.0136	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.47μs	0.638ns	2.39ns	0.0127	976 B
master	`CallElasticsearch`	net472	2.5μs	1.38ns	5.14ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.41μs	4.89ns	19ns	0.0135	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.75μs	0.81ns	2.92ns	0.014	1.02 KB
master	`CallElasticsearchAsync`	net472	2.7μs	1.69ns	6.32ns	0.167	1.05 KB
#6357	`CallElasticsearch`	net6.0	1.11μs	0.79ns	3.06ns	0.0135	976 B
#6357	`CallElasticsearch`	netcoreapp3.1	1.52μs	0.636ns	2.29ns	0.013	976 B
#6357	`CallElasticsearch`	net472	2.64μs	2.43ns	9.4ns	0.157	995 B
#6357	`CallElasticsearchAsync`	net6.0	1.27μs	1.81ns	6.79ns	0.0132	952 B
#6357	`CallElasticsearchAsync`	netcoreapp3.1	1.65μs	0.724ns	2.51ns	0.0135	1.02 KB
#6357	`CallElasticsearchAsync`	net472	2.62μs	1.94ns	7.5ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.28μs	0.408ns	1.53ns	0.0135	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.6μs	0.646ns	2.5ns	0.0127	952 B
master	`ExecuteAsync`	net472	1.86μs	1.25ns	4.84ns	0.144	915 B
#6357	`ExecuteAsync`	net6.0	1.2μs	1.8ns	6.74ns	0.0131	952 B
#6357	`ExecuteAsync`	netcoreapp3.1	1.67μs	0.862ns	3.11ns	0.0125	952 B
#6357	`ExecuteAsync`	net472	1.79μs	0.377ns	1.46ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.35μs	2.07ns	8.01ns	0.0327	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.38μs	3.19ns	11.9ns	0.0375	2.85 KB
master	`SendAsync`	net472	7.33μs	1.78ns	6.9ns	0.494	3.12 KB
#6357	`SendAsync`	net6.0	4.47μs	2.1ns	7.87ns	0.0316	2.31 KB
#6357	`SendAsync`	netcoreapp3.1	5.27μs	2.39ns	9.24ns	0.0395	2.85 KB
#6357	`SendAsync`	net472	7.36μs	2.14ns	8.29ns	0.493	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.57μs	0.551ns	1.99ns	0.0228	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.31μs	1.37ns	4.94ns	0.0216	1.64 KB
master	`EnrichedLog`	net472	2.56μs	1.45ns	5.62ns	0.249	1.57 KB
#6357	`EnrichedLog`	net6.0	1.53μs	1.02ns	3.94ns	0.0233	1.64 KB
#6357	`EnrichedLog`	netcoreapp3.1	2.14μs	1.13ns	4.39ns	0.0224	1.64 KB
#6357	`EnrichedLog`	net472	2.64μs	1.37ns	5.31ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	120μs	114ns	440ns	0.0602	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	122μs	156ns	584ns	0	0	4.28 KB
master	`EnrichedLog`	net472	151μs	267ns	1.03μs	0.673	0.224	4.46 KB
#6357	`EnrichedLog`	net6.0	120μs	250ns	968ns	0.0609	0	4.28 KB
#6357	`EnrichedLog`	netcoreapp3.1	124μs	140ns	541ns	0	0	4.28 KB
#6357	`EnrichedLog`	net472	151μs	173ns	648ns	0.68	0.227	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.12μs	0.905ns	3.5ns	0.0311	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.38μs	1.46ns	5.45ns	0.0306	2.2 KB
master	`EnrichedLog`	net472	4.88μs	1.47ns	5.69ns	0.319	2.02 KB
#6357	`EnrichedLog`	net6.0	3.04μs	1.08ns	4.03ns	0.0304	2.2 KB
#6357	`EnrichedLog`	netcoreapp3.1	4.26μs	1.39ns	5.21ns	0.0298	2.2 KB
#6357	`EnrichedLog`	net472	4.82μs	0.806ns	3.02ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.35μs	0.558ns	2.16ns	0.0162	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.72μs	0.984ns	3.81ns	0.0147	1.14 KB
master	`SendReceive`	net472	2.1μs	1.87ns	7.25ns	0.183	1.16 KB
#6357	`SendReceive`	net6.0	1.37μs	0.889ns	3.33ns	0.0157	1.14 KB
#6357	`SendReceive`	netcoreapp3.1	1.81μs	0.665ns	2.58ns	0.0153	1.14 KB
#6357	`SendReceive`	net472	2.05μs	1.29ns	4.99ns	0.184	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.79μs	0.924ns	3.58ns	0.0224	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.87μs	1.35ns	5.21ns	0.0213	1.65 KB
master	`EnrichedLog`	net472	4.36μs	1.97ns	7.38ns	0.323	2.04 KB
#6357	`EnrichedLog`	net6.0	2.82μs	0.685ns	2.56ns	0.0224	1.6 KB
#6357	`EnrichedLog`	netcoreapp3.1	3.92μs	2.41ns	9.03ns	0.0215	1.65 KB
#6357	`EnrichedLog`	net472	4.34μs	4.59ns	17.8ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	447ns	0.985ns	3.81ns	0.00811	576 B
master	`StartFinishSpan`	netcoreapp3.1	581ns	1.33ns	4.98ns	0.00753	576 B
master	`StartFinishSpan`	net472	585ns	0.801ns	3.1ns	0.0917	578 B
master	`StartFinishScope`	net6.0	476ns	0.665ns	2.58ns	0.00966	696 B
master	`StartFinishScope`	netcoreapp3.1	729ns	1.21ns	4.38ns	0.00953	696 B
master	`StartFinishScope`	net472	860ns	2.31ns	8.94ns	0.104	658 B
#6357	`StartFinishSpan`	net6.0	467ns	0.538ns	2.08ns	0.00812	576 B
#6357	`StartFinishSpan`	netcoreapp3.1	575ns	0.755ns	2.83ns	0.0078	576 B
#6357	`StartFinishSpan`	net472	594ns	1.09ns	4.23ns	0.0917	578 B
#6357	`StartFinishScope`	net6.0	494ns	1.91ns	7.4ns	0.00968	696 B
#6357	`StartFinishScope`	netcoreapp3.1	710ns	0.914ns	3.54ns	0.00934	696 B
#6357	`StartFinishScope`	net472	838ns	1.54ns	5.97ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	602ns	1.3ns	5.03ns	0.00969	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	895ns	2.22ns	8.32ns	0.00956	696 B
master	`RunOnMethodBegin`	net472	1.13μs	2.37ns	9.18ns	0.104	658 B
#6357	`RunOnMethodBegin`	net6.0	660ns	0.437ns	1.69ns	0.00987	696 B
#6357	`RunOnMethodBegin`	netcoreapp3.1	930ns	1.46ns	5.64ns	0.00939	696 B
#6357	`RunOnMethodBegin`	net472	1.12μs	1.82ns	7.03ns	0.104	658 B

andrewlock · 2024-11-26T17:35:10Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6357) (11.201M)   : 0, 11200766
    master (10.987M)   : 0, 10986728
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6357) (7.190M)   : 0, 7190495
    master (7.175M)   : 0, 7174684
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.577M)   : 0, 7577344

    section Manual
    master (11.201M)   : 0, 11201309

    section Manual + Automatic
    This PR (6357) (6.672M)   : 0, 6672490
    master (6.769M)   : 0, 6769214

    section DD_TRACE_ENABLED=0
    master (10.257M)   : 0, 10257268

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6357) (9.614M)   : 0, 9613923
    master (9.557M)   : 0, 9557319
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6357) (6.381M)   : 0, 6381065
    master (6.368M)   : 0, 6367805

    section Trace stats
    master (6.673M)   : 0, 6672869

    section Manual
    master (9.631M)   : 0, 9630961

    section Manual + Automatic
    This PR (6357) (6.014M)   : 0, 6014185
    master (5.951M)   : 0, 5951439

    section DD_TRACE_ENABLED=0
    master (8.900M)   : 0, 8899929

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6357) (9.826M)   : 0, 9825696
    master (9.199M)   : 0, 9198633
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6357) (6.440M)   : 0, 6440086
    master (6.083M)   : 0, 6082614
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.603M)   : 0, 6602631

    section Manual
    master (9.506M)   : 0, 9505886

    section Manual + Automatic
    This PR (6357) (5.764M)   : 0, 5764458
    master (5.789M)   : 0, 5788592

    section DD_TRACE_ENABLED=0
    master (8.972M)   : 0, 8971897

gleocadie added the area:crashtracking label Nov 26, 2024

github-actions bot added the area:profiler Issues related to the continous-profiler label Nov 26, 2024

gleocadie force-pushed the gleocadie/fix-gethread-description-missing branch from f73ce70 to 594da42 Compare November 26, 2024 14:29

gleocadie marked this pull request as ready for review November 26, 2024 14:44

gleocadie requested a review from a team as a code owner November 26, 2024 14:44

kevingosse approved these changes Nov 26, 2024

View reviewed changes

Fix missing GetThreadDescription symbol

f09ad5d

gleocadie force-pushed the gleocadie/fix-gethread-description-missing branch from 594da42 to f09ad5d Compare November 26, 2024 15:37

chrisnas approved these changes Nov 26, 2024

View reviewed changes

gleocadie merged commit c8ebcbc into master Nov 26, 2024
82 of 85 checks passed

gleocadie deleted the gleocadie/fix-gethread-description-missing branch November 26, 2024 18:29

github-actions bot added this to the vNext-v3 milestone Nov 26, 2024

dsim62 mentioned this pull request Dec 4, 2024

Profiler 3.6.1 error in iis "the procedure entry point GetThreadDescription could not be located un the dynamic link library" #6353

Open

veerbia pushed a commit that referenced this pull request Dec 16, 2024

[Crashtracker] Fix missing GetThreadDescription symbol (#6357)

b935bf0

andrewlock removed the area:profiler Issues related to the continous-profiler label Dec 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Crashtracker] Fix missing GetThreadDescription symbol #6357

[Crashtracker] Fix missing GetThreadDescription symbol #6357

gleocadie commented Nov 26, 2024 •

edited

Loading

kevingosse left a comment

datadog-ddstaging bot commented Nov 26, 2024 •

edited

Loading

andrewlock commented Nov 26, 2024 •

edited

Loading

chrisnas left a comment

andrewlock commented Nov 26, 2024

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

andrewlock commented Nov 26, 2024

[Crashtracker] Fix missing GetThreadDescription symbol #6357

[Crashtracker] Fix missing GetThreadDescription symbol #6357

Conversation

gleocadie commented Nov 26, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

kevingosse left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented Nov 26, 2024 • edited Loading

Datadog Report

andrewlock commented Nov 26, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

chrisnas left a comment

Choose a reason for hiding this comment

andrewlock commented Nov 26, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

andrewlock commented Nov 26, 2024

Throughput/Crank Report ⚡

gleocadie commented Nov 26, 2024 •

edited

Loading

datadog-ddstaging bot commented Nov 26, 2024 •

edited

Loading

andrewlock commented Nov 26, 2024 •

edited

Loading