[Tracing] Update telemetry metrics for OpenTelemtetry integration #6454

zacharycmontoya · 2024-12-17T17:05:11Z

Summary of changes

For the OpenTelemetry integration, update the tag generated for the span_created telemetry metric from integration_name:opentelemetry to integration_name:otel to align with other tracing libraries

Reason for change

Other tracing libraries generate span metrics using integration_name:otel.library or integration_name:otel to distinguish between OpenTelemetry Instrumentation Library usage or OpenTelemetry Custom Instrumentation usage. We cannot distinguish between the two, so we can simply use integration_name:otel

Implementation details

Update the static tag from integration_name:opentelemetry to integration_name:otel

Test coverage

This PR adds a test to assert the value of the integration_name tag attached to the span_creatted telemetry metric on all of our tracing integration tests. This was then used to test the updated tag value.

Other details

N/A

datadog-ddstaging · 2024-12-17T17:27:02Z

Datadog Report

Branch report: zach.montoya/otel-custom-instr-telemetry
Commit report: cb0a799
Test service: dd-trace-dotnet

❌ 15 Failed (0 Known Flaky), 452761 Passed, 2683 Skipped, 17h 48m 0.14s Total Time

❌ Failed Tests (15)

This report shows up to 5 failed tests.

HttpClient_SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.HttpMessageHandlerTests - Details

Expand for error

 
 Expected var spansCreated = spansCreatedByIntegration {empty} to contain key "integration_name:httpmessagehandler".

AssertIntegration_HandlesMultipleTelemetryPushes - Datadog.Trace.ClrProfiler.IntegrationTests.TelemetryHelperTests - Details

Expand for error

 Expected spansCreatedByIntegration not to be empty.
 Expected var spansCreated = spansCreatedByIntegration {empty} to contain key "integration_name:aerospike".

AssertIntegration_HandlesMultipleTelemetryPushes - Datadog.Trace.ClrProfiler.IntegrationTests.TelemetryHelperTests - Details

Expand for error

 Expected spansCreatedByIntegration not to be empty.
 Expected var spansCreated = spansCreatedByIntegration {empty} to contain key "integration_name:aerospike".

AssertIntegration_HandlesMultipleTelemetryPushes - Datadog.Trace.ClrProfiler.IntegrationTests.TelemetryHelperTests - Details

Expand for error

 Expected spansCreatedByIntegration not to be empty.
 Expected var spansCreated = spansCreatedByIntegration {empty} to contain key "integration_name:aerospike".

AssertIntegration_HandlesMultipleTelemetryPushes - Datadog.Trace.ClrProfiler.IntegrationTests.TelemetryHelperTests - Details

Expand for error

 Expected spansCreatedByIntegration not to be empty.
 Expected var spansCreated = spansCreatedByIntegration {empty} to contain key "integration_name:aerospike".

andrewlock · 2024-12-17T17:42:37Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6454) - mean (68ms)  : 66, 71
     .   : milestone, 68,
    master - mean (68ms)  : 66, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6454) - mean (976ms)  : 952, 999
     .   : milestone, 976,
    master - mean (973ms)  : 949, 997
     .   : milestone, 973,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6454) - mean (107ms)  : 105, 109
     .   : milestone, 107,
    master - mean (107ms)  : 105, 109
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6454) - mean (679ms)  : 665, 694
     .   : milestone, 679,
    master - mean (675ms)  : 657, 693
     .   : milestone, 675,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6454) - mean (91ms)  : 89, 92
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6454) - mean (634ms)  : 620, 647
     .   : milestone, 634,
    master - mean (630ms)  : 614, 646
     .   : milestone, 630,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6454) - mean (193ms)  : 189, 197
     .   : milestone, 193,
    master - mean (193ms)  : 188, 199
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (6454) - mean (1,102ms)  : 1068, 1135
     .   : milestone, 1102,
    master - mean (1,096ms)  : 1069, 1124
     .   : milestone, 1096,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6454) - mean (279ms)  : 274, 284
     .   : milestone, 279,
    master - mean (277ms)  : 272, 283
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6454) - mean (871ms)  : 838, 904
     .   : milestone, 871,
    master - mean (868ms)  : 841, 896
     .   : milestone, 868,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6454) - mean (266ms)  : 262, 270
     .   : milestone, 266,
    master - mean (266ms)  : 262, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6454) - mean (851ms)  : 815, 887
     .   : milestone, 851,
    master - mean (850ms)  : 814, 887
     .   : milestone, 850,

andrewlock · 2024-12-18T04:08:02Z

Benchmarks Report for tracer 🐌

Benchmarks for #6454 compared to master:

2 benchmarks are faster, with geometric mean 1.134
2 benchmarks are slower, with geometric mean 1.146
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.89μs	42.1ns	231ns	0.0191	0.00762	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.3μs	56.9ns	346ns	0.02	0.00998	0	5.8 KB
master	`StartStopWithChild`	net472	16.4μs	46.6ns	174ns	1.04	0.326	0.0979	6.21 KB
#6454	`StartStopWithChild`	net6.0	8.06μs	46.1ns	335ns	0.0119	0.00396	0	5.61 KB
#6454	`StartStopWithChild`	netcoreapp3.1	10.2μs	55.9ns	353ns	0.0245	0.0098	0	5.8 KB
#6454	`StartStopWithChild`	net472	16.2μs	39ns	151ns	1.06	0.331	0.105	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	505μs	187ns	674ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	665μs	191ns	713ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	851μs	601ns	2.25μs	0.425	3.3 KB
#6454	`WriteAndFlushEnrichedTraces`	net6.0	477μs	180ns	672ns	0	2.7 KB
#6454	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	661μs	377ns	1.46μs	0	2.7 KB
#6454	`WriteAndFlushEnrichedTraces`	net472	853μs	467ns	1.75μs	0.425	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	159μs	1.17μs	11.7μs	0.155	14.47 KB
master	`SendRequest`	netcoreapp3.1	171μs	989ns	8.85μs	0.16	17.27 KB
master	`SendRequest`	net472	0.00147ns	0.000331ns	0.00119ns	0	0 b
#6454	`SendRequest`	net6.0	153μs	892ns	8.18μs	0.148	14.47 KB
#6454	`SendRequest`	netcoreapp3.1	185μs	1.77μs	17.7μs	0.166	17.27 KB
#6454	`SendRequest`	net472	0.00625ns	0.0021ns	0.00814ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6454

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.66 KB	41.89 KB	228 B	0.55%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	574μs	3.16μs	19.7μs	0.571	0	0	41.6 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	667μs	3.5μs	18.2μs	0.319	0	0	41.66 KB
master	`WriteAndFlushEnrichedTraces`	net472	874μs	3.72μs	14.4μs	8.19	2.59	0.431	53.28 KB
#6454	`WriteAndFlushEnrichedTraces`	net6.0	564μs	2.58μs	15.5μs	0.53	0	0	41.69 KB
#6454	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	673μs	3.64μs	21.2μs	0.319	0	0	41.89 KB
#6454	`WriteAndFlushEnrichedTraces`	net472	862μs	1.98μs	9.9μs	8.39	2.52	0.419	53.3 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.28μs	1.12ns	4.19ns	0.0142	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.86μs	1.63ns	6.3ns	0.0138	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.11μs	1.82ns	7.04ns	0.156	0.00105	987 B
#6454	`ExecuteNonQuery`	net6.0	1.24μs	0.877ns	3.16ns	0.0143	0	1.02 KB
#6454	`ExecuteNonQuery`	netcoreapp3.1	1.7μs	1.27ns	4.9ns	0.0138	0	1.02 KB
#6454	`ExecuteNonQuery`	net472	2.07μs	1.23ns	4.62ns	0.156	0.00103	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.25μs	0.547ns	2.05ns	0.0138	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.61μs	1.32ns	5.13ns	0.0128	976 B
master	`CallElasticsearch`	net472	2.49μs	2.37ns	9.17ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.35μs	0.4ns	1.44ns	0.013	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.76μs	1.28ns	4.95ns	0.014	1.02 KB
master	`CallElasticsearchAsync`	net472	2.68μs	0.672ns	2.42ns	0.166	1.05 KB
#6454	`CallElasticsearch`	net6.0	1.33μs	0.671ns	2.51ns	0.0139	976 B
#6454	`CallElasticsearch`	netcoreapp3.1	1.56μs	1.08ns	4.17ns	0.0131	976 B
#6454	`CallElasticsearch`	net472	2.43μs	1.11ns	4.15ns	0.157	995 B
#6454	`CallElasticsearchAsync`	net6.0	1.31μs	1.19ns	4.6ns	0.0131	952 B
#6454	`CallElasticsearchAsync`	netcoreapp3.1	1.61μs	0.636ns	2.38ns	0.0137	1.02 KB
#6454	`CallElasticsearchAsync`	net472	2.59μs	0.957ns	3.45ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.34μs	0.61ns	2.28ns	0.0139	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.59μs	0.735ns	2.75ns	0.0129	952 B
master	`ExecuteAsync`	net472	1.84μs	0.58ns	2.17ns	0.145	915 B
#6454	`ExecuteAsync`	net6.0	1.43μs	0.442ns	1.53ns	0.0136	952 B
#6454	`ExecuteAsync`	netcoreapp3.1	1.65μs	0.691ns	2.58ns	0.0123	952 B
#6454	`ExecuteAsync`	net472	1.82μs	0.393ns	1.47ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.46μs	0.961ns	3.72ns	0.0313	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.12μs	1.94ns	6.98ns	0.0361	2.85 KB
master	`SendAsync`	net472	7.37μs	1.27ns	4.57ns	0.494	3.12 KB
#6454	`SendAsync`	net6.0	4.36μs	2.08ns	7.78ns	0.0327	2.31 KB
#6454	`SendAsync`	netcoreapp3.1	5.29μs	2.84ns	11ns	0.0371	2.85 KB
#6454	`SendAsync`	net472	7.31μs	1.35ns	5.24ns	0.493	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.46μs	0.521ns	1.88ns	0.0228	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.25μs	9.33ns	36.1ns	0.0218	1.64 KB
master	`EnrichedLog`	net472	2.67μs	1.31ns	4.9ns	0.25	1.57 KB
#6454	`EnrichedLog`	net6.0	1.58μs	2.78ns	10.8ns	0.0231	1.64 KB
#6454	`EnrichedLog`	netcoreapp3.1	2.05μs	1.41ns	5.44ns	0.0218	1.64 KB
#6454	`EnrichedLog`	net472	2.75μs	1.46ns	5.65ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	119μs	165ns	616ns	0.0598	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	122μs	179ns	691ns	0	0	4.28 KB
master	`EnrichedLog`	net472	153μs	130ns	503ns	0.687	0.229	4.46 KB
#6454	`EnrichedLog`	net6.0	118μs	232ns	899ns	0.0588	0	4.28 KB
#6454	`EnrichedLog`	netcoreapp3.1	122μs	86.9ns	313ns	0	0	4.28 KB
#6454	`EnrichedLog`	net472	152μs	329ns	1.27μs	0.686	0.229	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.96μs	0.942ns	3.65ns	0.0312	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.11μs	1.58ns	6.11ns	0.0289	2.2 KB
master	`EnrichedLog`	net472	4.86μs	1.22ns	4.74ns	0.32	2.02 KB
#6454	`EnrichedLog`	net6.0	2.99μs	1.69ns	6.33ns	0.0314	2.2 KB
#6454	`EnrichedLog`	netcoreapp3.1	4.15μs	2.13ns	8.24ns	0.0291	2.2 KB
#6454	`EnrichedLog`	net472	4.85μs	1.3ns	5.04ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.4μs	0.47ns	1.76ns	0.0162	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.82μs	8.41ns	32.6ns	0.0155	1.14 KB
master	`SendReceive`	net472	2.13μs	0.448ns	1.74ns	0.184	1.16 KB
#6454	`SendReceive`	net6.0	1.35μs	0.974ns	3.64ns	0.0161	1.14 KB
#6454	`SendReceive`	netcoreapp3.1	1.73μs	0.95ns	3.68ns	0.0155	1.14 KB
#6454	`SendReceive`	net472	2.1μs	1.7ns	6.37ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.78μs	0.78ns	2.92ns	0.0224	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.87μs	2.61ns	10.1ns	0.0213	1.65 KB
master	`EnrichedLog`	net472	4.36μs	5.45ns	21.1ns	0.324	2.04 KB
#6454	`EnrichedLog`	net6.0	2.7μs	1.99ns	7.73ns	0.0228	1.6 KB
#6454	`EnrichedLog`	netcoreapp3.1	3.9μs	2.26ns	8.77ns	0.0216	1.65 KB
#6454	`EnrichedLog`	net472	4.34μs	2.14ns	7.99ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6454

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472	1.125	659.22	741.56

Faster 🎉 in #6454

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.141	652.47	571.84	several?
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.127	593.56	526.49

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	413ns	0.199ns	0.769ns	0.00802	576 B
master	`StartFinishSpan`	netcoreapp3.1	639ns	3.5ns	20.1ns	0.00752	576 B
master	`StartFinishSpan`	net472	660ns	0.547ns	2.12ns	0.0917	578 B
master	`StartFinishScope`	net6.0	594ns	0.422ns	1.63ns	0.00982	696 B
master	`StartFinishScope`	netcoreapp3.1	745ns	0.867ns	3.36ns	0.00932	696 B
master	`StartFinishScope`	net472	833ns	1.4ns	5.41ns	0.105	658 B
#6454	`StartFinishSpan`	net6.0	446ns	0.299ns	1.16ns	0.00812	576 B
#6454	`StartFinishSpan`	netcoreapp3.1	572ns	0.471ns	1.82ns	0.00774	576 B
#6454	`StartFinishSpan`	net472	743ns	1.55ns	6ns	0.0916	578 B
#6454	`StartFinishScope`	net6.0	526ns	0.274ns	1.06ns	0.00979	696 B
#6454	`StartFinishScope`	netcoreapp3.1	725ns	0.728ns	2.82ns	0.00951	696 B
#6454	`StartFinishScope`	net472	855ns	0.855ns	3.31ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6454

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.168	637.21	744.19

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	638ns	0.866ns	3.35ns	0.00963	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	894ns	0.805ns	3.12ns	0.00927	696 B
master	`RunOnMethodBegin`	net472	1.1μs	1.08ns	4.18ns	0.104	658 B
#6454	`RunOnMethodBegin`	net6.0	743ns	0.541ns	1.95ns	0.00967	696 B
#6454	`RunOnMethodBegin`	netcoreapp3.1	952ns	0.974ns	3.77ns	0.00916	696 B
#6454	`RunOnMethodBegin`	net472	1.13μs	0.545ns	2.11ns	0.104	658 B

andrewlock · 2024-12-19T00:25:53Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6454) (11.172M)   : 0, 11171561
    master (11.166M)   : 0, 11165619
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6454) (7.226M)   : 0, 7226315
    master (7.232M)   : 0, 7232435
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.555M)   : 0, 7555239

    section Manual
    master (11.218M)   : 0, 11218357

    section Manual + Automatic
    This PR (6454) (6.688M)   : 0, 6687605
    master (6.695M)   : 0, 6694720

    section DD_TRACE_ENABLED=0
    master (10.195M)   : 0, 10194994

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6454) (9.495M)   : 0, 9495307
    master (9.350M)   : 0, 9350086
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6454) (6.375M)   : 0, 6375065
    master (6.223M)   : 0, 6222880

    section Trace stats
    master (6.644M)   : 0, 6644302

    section Manual
    master (9.490M)   : 0, 9490052

    section Manual + Automatic
    This PR (6454) (5.910M)   : 0, 5909686
    master (5.826M)   : 0, 5826117

    section DD_TRACE_ENABLED=0
    master (8.806M)   : 0, 8806093

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6454) (9.903M)   : 0, 9902503
    master (10.038M)   : 0, 10038108
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6454) (6.509M)   : 0, 6509367
    master (6.759M)   : 0, 6759031
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.327M)   : 0, 7327150

    section Manual
    master (10.148M)   : 0, 10147695

    section Manual + Automatic
    This PR (6454) (5.872M)   : crit ,0, 5872352
    master (6.270M)   : 0, 6270298

    section DD_TRACE_ENABLED=0
    master (9.572M)   : 0, 9571995

zacharycmontoya · 2024-12-19T20:59:54Z

tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/Helpers/TelemetryHelper.cs

+            {
+                spansCreatedByIntegration.Should().NotBeEmpty();
+
+                var spansCreated = spansCreatedByIntegration.Should().ContainKey($"integration_name:{integrationNameTagValue}").WhoseValue;


This adds a new check (for all our integration tests!) that when the integration is enabled we also receive a spans_created metric that corresponds to the enabled integration.

The "otel" check above shows how this is the only integration whose tag value differs from its corresponding IntegrationId.ToString() 😅

…sserting they have the tag "integration_name:IntegrationId.ToString()"

…pan_created telemetry metric from `integration_name:opentelemetry` to `integration_name:otel` to align with other tracing libraries

github-actions bot added the area:tests unit tests, integration tests label Dec 17, 2024

zacharycmontoya force-pushed the zach.montoya/otel-custom-instr-telemetry branch from 58f7387 to 7a16426 Compare December 18, 2024 22:30

zacharycmontoya changed the title ~~Update tags for spans_created metrics~~ [Tracing] Update telemetry metrics for OpenTelemtetry integration Dec 18, 2024

zacharycmontoya commented Dec 19, 2024

View reviewed changes

zacharycmontoya force-pushed the zach.montoya/otel-custom-instr-telemetry branch from 7a16426 to b2025e7 Compare December 19, 2024 21:00

zacharycmontoya added 2 commits December 20, 2024 11:19

Add test to ensure that we are collecting spans_created metrics and a…

61bdaf9

…sserting they have the tag "integration_name:IntegrationId.ToString()"

For the OpenTelemetry integration, update the tag generated for the s…

cb0a799

…pan_created telemetry metric from `integration_name:opentelemetry` to `integration_name:otel` to align with other tracing libraries

zacharycmontoya force-pushed the zach.montoya/otel-custom-instr-telemetry branch from b2025e7 to cb0a799 Compare December 20, 2024 19:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tracing] Update telemetry metrics for OpenTelemtetry integration #6454

[Tracing] Update telemetry metrics for OpenTelemtetry integration #6454

zacharycmontoya commented Dec 17, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 17, 2024 •

edited

Loading

andrewlock commented Dec 17, 2024 •

edited

Loading

andrewlock commented Dec 18, 2024 •

edited

Loading

Raw results

Raw results

Raw results

More allocations ⚠️ in #6454

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6454

Faster 🎉 in #6454

Raw results

Slower ⚠️ in #6454

Raw results

andrewlock commented Dec 19, 2024 •

edited

Loading

zacharycmontoya Dec 19, 2024

[Tracing] Update telemetry metrics for OpenTelemtetry integration #6454

Are you sure you want to change the base?

[Tracing] Update telemetry metrics for OpenTelemtetry integration #6454

Conversation

zacharycmontoya commented Dec 17, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Dec 17, 2024 • edited Loading

Datadog Report

❌ Failed Tests (15)

andrewlock commented Dec 17, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Dec 18, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #6454

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6454

Faster 🎉 in #6454

Raw results

Slower ⚠️ in #6454

Raw results

andrewlock commented Dec 19, 2024 • edited Loading

Throughput/Crank Report ⚡

zacharycmontoya Dec 19, 2024

Choose a reason for hiding this comment

zacharycmontoya commented Dec 17, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 17, 2024 •

edited

Loading

andrewlock commented Dec 17, 2024 •

edited

Loading

andrewlock commented Dec 18, 2024 •

edited

Loading

andrewlock commented Dec 19, 2024 •

edited

Loading