Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone AppSec improvements #3710

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Dec 18, 2024

Motivation

While chasing down some flakyness, we came out with some improvements to the tests

Changes

  • Use /returnheaders endpoint for the initial setup/assert, since it's more lightweight than /requestdownstream, the latter creates two requests instead of 1, adding unnecessary pressure to the weblog.
  • Use different trace and parent ids for each test. This way all the spans are not connected to the same parent, and a single test will fail if the spans are not properly flushed, instead of all of them failing together. This is useful for flake investigation.
  • Add an assert about the weblog response to make sure it has content before calling json.loads() on it.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@gnufede gnufede requested review from a team as code owners December 18, 2024 11:39
@gnufede gnufede marked this pull request as draft December 18, 2024 17:20
@gnufede
Copy link
Member Author

gnufede commented Dec 18, 2024

Switched back to draft as it apparently breaks all iast standalone tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants