Fix ipv6 connection hangs when in v4 environment #1734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since connection will be reset to
USE_IPV4_IPV6_RANDOM
when connection failed even in pure v4 environment.Telegram/TMessagesProj/jni/tgnet/Connection.cpp
Lines 699 to 702 in 0e17caa
However, it does not reset
lastProtocolUsefullData
correctly ifconnectionType
is notConnectionTypeGeneric
(usually problem occurs whenConnectionTypeGenericMedia
) andlastProtocolUsefullData
will be setfalse
only here.Telegram/TMessagesProj/jni/tgnet/Connection.cpp
Lines 299 to 311 in 0e17caa
So it always connect as ipv6 if
lastProtocolUsefullData
istrue
andRAND_bytes
got 0, 3, 6 even there is no ipv6 capability.I try to fix it using always reset
lastProtocolUsefullData
tofalse
whenUSE_IPV4_IPV6_RANDOM
is meet.