Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project icon to README #2959

Draft
wants to merge 4 commits into
base: 1.20-pre4
Choose a base branch
from
Draft

Add project icon to README #2959

wants to merge 4 commits into from

Conversation

haykam821
Copy link
Contributor

No description provided.

@haykam821 haykam821 marked this pull request as draft January 14, 2022 21:17
@modmuss50
Copy link
Member

Doesnt look so great here: https://github.com/haykam821/yarn/tree/readme-project-icon

@frqnny
Copy link
Contributor

frqnny commented Jan 14, 2022

can you change the image based on light/dark?…

@liach
Copy link
Contributor

liach commented Jan 15, 2022

Is this image good license-wise? I am afraid.

Maybe add a width="25" in the img tag might help.

can you change the image based on light/dark?…

Yes. It's already transparent.

liach
liach reviewed Jan 18, 2022
View reviewed changes
README.md
@@ -1,4 +1,4 @@
# Yarn
# <img src="https://raw.githubusercontent.com/FabricMC/community/c6f24b3b651517fc6b1451e9a63ed4438366b880/media/unascribed/png/yarn.png" style="height: 1.25em; vertical-align: bottom;" alt="Yarn logo" /> Yarn

This comment was marked as outdated.

Sign in to view

@haykam821 haykam821 changed the base branch from 1.18.1 to 22w03a January 19, 2022 18:39
@haykam821 haykam821 changed the base branch from 22w03a to 22w05a February 2, 2022 21:30
@haykam821 haykam821 changed the base branch from 22w05a to 22w07a February 18, 2022 14:44
@haykam821 haykam821 changed the base branch from 22w07a to 1.18.2-pre1 February 18, 2022 17:18
@haykam821 haykam821 changed the base branch from 1.18.2-pre1 to 1.18.2-pre3 February 23, 2022 20:29
@enbrain enbrain added the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Mar 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

🚀 Target branch has been updated to 1.18.2

@github-actions github-actions bot changed the base branch from 1.18.2-pre3 to 1.18.2 March 3, 2022 03:24
@github-actions github-actions bot added release A PR that targets a release version of Minecraft and removed update-base Add this label to a pull request to automatically change the target branch to the default branch. labels Mar 3, 2022
@modmuss50
Copy link
Member

@haykam821 I see you have updated the branch on this so I assume you are still maintaining it? Are you able to fix it as its trival to merge once it works as expected.

@haykam821 haykam821 changed the base branch from 1.18.2 to 22w12a March 25, 2022 16:05
@haykam821 haykam821 changed the base branch from 22w12a to 22w15a April 20, 2022 04:18
@liach
Copy link
Contributor

liach commented Apr 20, 2022

@haykam821 What do you suggest to do with oversized icon? Put it as separate image on top or make it sized like a small icon in my suggestion?

@liach liach added snapshot A PR that targets a snapshot version of Minecraft and removed release A PR that targets a release version of Minecraft labels Apr 20, 2022
@haykam821 haykam821 changed the base branch from 22w15a to 22w18a May 4, 2022 19:10
@haykam821 haykam821 changed the base branch from 22w18a to 1.19-pre1 May 18, 2022 21:24
@haykam821 haykam821 changed the base branch from 1.19-pre1 to 1.19-pre2 May 23, 2022 17:42
@haykam821 haykam821 changed the base branch from 1.19-pre2 to 1.19-pre4 May 30, 2022 17:03
@haykam821 haykam821 changed the base branch from 1.19-pre4 to 1.19-pre5 June 1, 2022 18:17
@haykam821 haykam821 changed the base branch from 1.19-pre5 to 1.19 June 14, 2022 03:28
@haykam821 haykam821 added release A PR that targets a release version of Minecraft and removed snapshot A PR that targets a snapshot version of Minecraft labels Jun 14, 2022
@modmuss50
Copy link
Member

Do you still plan to fix this PR? If not I will close it.

@haykam821 haykam821 changed the base branch from 1.19 to 1.19.1 July 28, 2022 17:47
@NebelNidas
Copy link
Member

Not sure if GitHub has changed their styling in the meantime, but IMO it looks fine now:
image

@liach liach added the update-base Add this label to a pull request to automatically change the target branch to the default branch. label May 5, 2023
@github-actions github-actions bot changed the base branch from 1.19.1 to 23w18a May 5, 2023 16:30
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

🚀 Target branch has been updated to 23w18a

@liach liach added snapshot A PR that targets a snapshot version of Minecraft and removed release A PR that targets a release version of Minecraft labels May 5, 2023
@YanisBft YanisBft added update-base Add this label to a pull request to automatically change the target branch to the default branch. and removed update-base Add this label to a pull request to automatically change the target branch to the default branch. labels May 21, 2023
@github-actions github-actions bot changed the base branch from 23w18a to 1.20-pre4 May 21, 2023 21:41
@github-actions
Copy link
Contributor

🚀 Target branch has been updated to 1.20-pre4

@github-actions
Copy link
Contributor

🚨 Unable to automatically update branch with the latest changes

@github-actions github-actions bot removed the update-base Add this label to a pull request to automatically change the target branch to the default branch. label May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YanisBft YanisBft YanisBft approved these changes

@liach liach liach approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@haykam821 @modmuss50 @frqnny @liach @NebelNidas @YanisBft @enbrain