Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nmcli to the linux installer #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ikreb7
Copy link
Contributor

@ikreb7 ikreb7 commented Nov 8, 2019

I want to get more independent from dbus because this is the biggest source of error. So I think we should switch tonmcli. What do you think about it?

This is only the start and I will soon add more. I want only start a discussion yet what is your opinion and what I should change or improve. You are also welcome to add stuff. I tested it only with eap-ttls-pap yet.

@ikreb7 ikreb7 mentioned this pull request Nov 8, 2019
@twoln
Copy link
Contributor

twoln commented Nov 9, 2019

I have been meaning to go in this direction for quite a while, but did not get a free slot long enough. With nmcli it is to 100% obvious it Python is the right way to go, one could go back to what we had once - a bash script.
If you want to give it a go, then please go ahead, but I would prefer to define a separate device module so that we could keep the current one while developing the new one in parallel and having it available in test mode.

@ikreb7
Copy link
Contributor Author

ikreb7 commented Nov 13, 2019

In my opinion, it is better to keep it in one file, so if nmcli doesn't work we could simple step backwards and use still dbus.

But actually I would prefer if we go backwards to a bash script. Would I get support from you if I develop a bash script? I would use the old bash file from you.

@twoln
Copy link
Contributor

twoln commented Nov 23, 2020

Since nmcli is added to the bash installer, I suggest we do not extend the Python one and close this pull request without merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants