Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorbet: Add an RBI file for PyCall #18994

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Dec 24, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

/opt/homebrew/Library/Taps/homebrew/homebrew-formula-analytics/lib/pycall-setup.rb:7: Unable to resolve constant PyCall https://srb.help/5002
     7 |  extend PyCall::Import

@Bo98
Copy link
Member

Bo98 commented Dec 24, 2024

PyCall gem is formula-analytics specific: https://github.com/Homebrew/homebrew-formula-analytics/blob/master/Gemfile#L7. Does it work if you move this to a pycall-setup.rbi?

@issyl0 issyl0 force-pushed the sorbet-formula-analytics-tap-pycall-rbi branch 2 times, most recently from 0c30edd to 54af969 Compare December 27, 2024 23:49
- This is used in `Homebrew/formula-analytics` to
  import Python modules, specifically the InfluxDB
  client we need.
- Sorbet complained that it couldn‘t find the
  `PyCall` reference, so let’s teach Sorbet about
  it.
@issyl0 issyl0 force-pushed the sorbet-formula-analytics-tap-pycall-rbi branch from 54af969 to ec43b24 Compare December 28, 2024 00:25
@Bo98
Copy link
Member

Bo98 commented Dec 28, 2024

Ah sorry, I meant moving it to be an rbi file that lives alongside pycall-setup.rb over in the formula-analytics repo. Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants