Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps command: add --include-implicit flag #19000

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Dec 24, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is a follow-up of Homebrew/homebrew-core#201901: it adds the --include-implicit flag to brew deps and brew uses.

Once this is merged we can update the scheduled.yml workflow on homebrew-core to use this command instead of the current ruby one-liner.

@Moisan Moisan force-pushed the deps-include-implicit branch from 16a1da9 to d5e94f2 Compare December 24, 2024 20:28
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Still needs some work. What is an implicit dependency?

@@ -37,6 +37,8 @@ class UnavailableFormula < T::Struct
switch "--eval-all",
description: "Evaluate all available formulae and casks, whether installed or not, to show " \
"their dependents."
switch "--include-implicit",
description: "Include formulae that specify <formula> as a `:build` dependency."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be wrong?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I think I copy-pasted from somewhere else and forgot to update the description.

@Moisan
Copy link
Member Author

Moisan commented Dec 27, 2024

What is an implicit dependency?

I took the definition of implicit dependency from formula.rb

They are also used in a lot in dependency_collector.rb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants