-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PDNS): update custom resolver profile and views[DO NOT MERGE] #5625
Open
arjunchauhanibm
wants to merge
22
commits into
IBM-Cloud:master
Choose a base branch
from
arjunchauhanibm:add_views
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjunchauhanibm
changed the title
feat(PDNS): update custom resolver profile and views
feat(PDNS): update custom resolver profile and views[DO NOT MERGE]
Sep 6, 2024
Signing off the Terraform support for provider |
ibm/service/dnsservices/data_source_ibm_private_dns_custom_resolver_forwarding_rules.go
Show resolved
Hide resolved
ibm/service/dnsservices/data_source_ibm_private_dns_custom_resolver_forwarding_rules.go
Outdated
Show resolved
Hide resolved
arjunchauhanibm
force-pushed
the
add_views
branch
from
October 27, 2024 10:16
5c37702
to
5f31a2b
Compare
ibm/service/dnsservices/data_source_ibm_private_dns_custom_resolver_forwarding_rules.go
Outdated
Show resolved
Hide resolved
ibm/service/dnsservices/resource_ibm_private_dns_custom_resolver.go
Outdated
Show resolved
Hide resolved
ibm/service/dnsservices/resource_ibm_private_dns_custom_resolver_forwarding_rule.go
Outdated
Show resolved
Hide resolved
Testing Doc: https://ibm.ent.box.com/notes/1654095457908 |
hkantare
reviewed
Nov 12, 2024
ibm/service/dnsservices/data_source_ibm_private_dns_custom_resolver_forwarding_rules.go
Show resolved
Hide resolved
Approved PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing: