-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config aggregator terraform changes #5683
Open
Ramya-c4
wants to merge
21
commits into
IBM-Cloud:master
Choose a base branch
from
Ramya-c4:config-aggregator-terraform-changes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
config aggregator terraform changes #5683
Ramya-c4
wants to merge
21
commits into
IBM-Cloud:master
from
Ramya-c4:config-aggregator-terraform-changes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, Run all the test cases for the new resources and datasources you are creating and attach screenshots. |
Ramya-c4
force-pushed
the
config-aggregator-terraform-changes
branch
5 times, most recently
from
September 27, 2024 06:13
042dbf6
to
3226695
Compare
VaishnaviGopal
previously approved these changes
Sep 27, 2024
Ramya-c4
force-pushed
the
config-aggregator-terraform-changes
branch
from
September 27, 2024 06:44
9b983b2
to
96f0cf0
Compare
Ramya-c4
dismissed
VaishnaviGopal’s stale review
September 27, 2024 06:45
The merge-base changed after approval.
Ramya-c4
force-pushed
the
config-aggregator-terraform-changes
branch
11 times, most recently
from
September 27, 2024 08:44
427d602
to
c9c67d1
Compare
* discourage use of ibm_container_bind_service Signed-off-by: Bence Vidosits <[email protected]> * fix link --------- Signed-off-by: Bence Vidosits <[email protected]> Co-authored-by: Bence Vidosits <[email protected]>
* add changes for test bucket endpoints * update code --------- Co-authored-by: Deeksha Sharma <[email protected]>
* Add support for Code Engine functions * update .secrets.baseline * remove unnecessary check
…i tags calls (IBM-Cloud#5641) * Deprecated ibm_resource_access_tag in favor of ibm_iam_access_tag * changes * Fix * Changed resource to speed up tests * fix * PR changes * PR changes * Added new context functions. Now the code handles the error in the response on resource tags calls. * Fixed 5635 * Fix * Fixed * Removed logs line
* IAM Policy Assignment: S2S Policy Assignments ET and AG Signed-off-by: Alluri-Varma <[email protected]> * resolving CVE's for EPAP * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG --------- Signed-off-by: Alluri-Varma <[email protected]> Co-authored-by: Alluri-Varma <[email protected]>
* migration of vpc-go-sdk to 0.58.0 * make fmt changes
…ud#5640) Signed-off-by: Somanath Chavan <[email protected]>
…enable force deletion by default (IBM-Cloud#5660) * Updated schematics go sdk version to v0.3.0 * Fix issue5475 * Changed the supported tf version for ws creation from 1.4-1.9
Co-authored-by: Ujjwal Kumar <[email protected]>
IBM-Cloud#5619) * Adding new resource ibm_cos_lifecycle_configuration to manage lifecycle policy for bucket * Adding the data source changes * Data source changes * Adding the import documentation * Addressing the review comments * Updating the resource to use context * Changes to add multiple abort_incomplete_multipart_upload
Ramya-c4
force-pushed
the
config-aggregator-terraform-changes
branch
from
September 27, 2024 08:47
d49a324
to
aa7ad24
Compare
…ges' into config-aggregator-terraform-changes
Ramya-c4
force-pushed
the
config-aggregator-terraform-changes
branch
from
September 27, 2024 09:19
2d0fc49
to
ccfe76c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git issue : https://github.ibm.com/devx-app-services/configuration-aggregator-planning/issues/326
terraform output
the test case o/p