Add SDSaaS to terraform provider #5772
Conversation
|
The users will have to set the |
Dylan-Christopherson
force-pushed
the
dchris-sdsaas-terraform
branch
2 times, most recently
from
433ee5e to
4ac83e3
Compare
Dylan-Christopherson
force-pushed
the
dchris-sdsaas-terraform
branch
from
90724f3 to
fcf8cad
Compare
| @@ -3523,6 +3534,28 @@ func (c *Config) ClientSession() (interface{}, error) { | |||
| session.codeEngineClientErr = fmt.Errorf("Error occurred while configuring Code Engine service: %q", err) | |||
| } | |||
|
|
|||
| // Construct an instance of the 'sdsaas' service. | |||
| if session.sdsaasClientErr == nil { | |||
There was a problem hiding this comment.
If service supports private endpoints can we construct endpoints based on private
You can some other services piece of code like
// VPC Service
vpcurl := ContructEndpoint(fmt.Sprintf("%s.iaas", c.Region), fmt.Sprintf("%s/v1", cloudEndpoint))
if c.Visibility == "private" || c.Visibility == "public-and-private" {
vpcurl = ContructEndpoint(fmt.Sprintf("%s.private.iaas", c.Region), fmt.Sprintf("%s/v1", cloudEndpoint))
}
if fileMap != nil && c.Visibility != "public-and-private" {
vpcurl = fileFallBack(fileMap, c.Visibility, "IBMCLOUD_IS_NG_API_ENDPOINT", c.Region, vpcurl)
}
```
There was a problem hiding this comment.
@hkantare This service does not support private endpoints.
| return tfErr.GetDiag() | ||
| } | ||
|
|
||
| d.SetId(*host.ID) |
There was a problem hiding this comment.
How long does the creation of host takes If it moves to different state like starting,....running can we have wait logic to wait untill hosts comes to desired state
There was a problem hiding this comment.
@hkantare The host resource creation usually is almost instantaneous. The host resource here is just a representation for the end user and not a host that would go thru starting/running etc like eg a VM would.
Dylan-Christopherson
force-pushed
the
dchris-sdsaas-terraform
branch
from
fcf8cad to
12e0ca5
Compare
This PR adds terraform support for the software defined storage offering (Ceph as a Service). Terraform resources include volumes and hosts.
Community Note
Output from acceptance testing: