[Resource] [Datasource] Power add VSN functionality to datasources an… #5854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexander-Kita
requested review from
yussufsh,
hkantare,
michaelkad and
ismirlia
Alexander-Kita
force-pushed
the
vsn-instances
branch
from
de3cf43 to
0274928
Compare
yussufsh
reviewed
Dec 18, 2024
| @@ -1703,6 +1816,12 @@ func createPVMInstance(d *schema.ResourceData, client *instance.IBMPIInstanceCli | |||
| if tags, ok := d.GetOk(Arg_UserTags); ok { | |||
| body.UserTags = flex.FlattenSet(tags.(*schema.Set)) | |||
| } | |||
| if vsn, ok := d.GetOk(Arg_VirtualSerialNumber); ok { | |||
| vsnListType := vsn.([]interface{}) | |||
There was a problem hiding this comment.
Not sure why this is declared here and passed as a parameter to the func in next line?
There was a problem hiding this comment.
It needs to convert the list type (what terraform is taking) to a CreateServerVirtualSerialNumber model to send to SB
Alexander-Kita
force-pushed
the
vsn-instances
branch
from
0274928 to
7e91eb2
Compare
yussufsh
requested changes
Dec 23, 2024
| Description: "Description of virtual serial number.", | ||
| Type: schema.TypeString, | ||
| }, | ||
| Attr_InstanceID: { |
There was a problem hiding this comment.
IMO this attr looks like redundant as it is same as Arg_InstanceID isn't?
There was a problem hiding this comment.
It will be only when Arg_InstanceID is supplied. However, it is needed whenever the argument is not supplied as it will be a list of virtual serial numbers with different values for InstanceID.
Alexander-Kita
force-pushed
the
vsn-instances
branch
from
7e91eb2 to
4d5d6b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing:
pi_virtual_serial_number (d):
pi_virtual_serial_numbers (d):
pi_virtual_serial_number (r)
pi_instance (d)
pi_instances (d)
pi_instance (r)