fix(errors): improve message when version validation fails

JS-DevTools · Oct 24, 2023 · 1fad02a · 1fad02a
1 parent 6fd3bc8
commit 1fad02a
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 6 deletions.
diff --git a/dist/main.js b/dist/main.js
diff --git a/dist/main.js.map b/dist/main.js.map
diff --git a/src/__tests__/read-manifest.test.ts b/src/__tests__/read-manifest.test.ts
@@ -217,6 +217,7 @@ describe("readManifest", () => {
     const result = subject.readManifest(directory);
 
     await expect(result).rejects.toThrow(errors.InvalidPackageVersionError);
+    await expect(result).rejects.toThrow(/42/iu);
   });
 
   it("should error if publishConfig is invalid", async () => {

diff --git a/src/errors.ts b/src/errors.ts
@@ -69,7 +69,9 @@ export class InvalidPackageNameError extends TypeError {
 
 export class InvalidPackageVersionError extends TypeError {
   public constructor(value: unknown) {
-    super(`Package version must be a string, got "${String(value)}"`);
+    super(
+      `Package version must be a valid semantic version, got "${String(value)}"`
+    );
     this.name = "InvalidPackageVersionError";
   }
 }

diff --git a/src/read-manifest.ts b/src/read-manifest.ts
@@ -121,7 +121,7 @@ export async function readManifest(
   }
 
   if (typeof version !== "string") {
-    throw new errors.InvalidPackageVersionError(version);
+    throw new errors.InvalidPackageVersionError(manifestJson["version"]);
   }
 
   if (
-Original file line number
+Diff line change
@@ Expand Up / @@ -121,7 +121,7 @@ export async function readManifest( @@
       }
       if (typeof version !== "string") {
-        throw new errors.InvalidPackageVersionError(version);
+        throw new errors.InvalidPackageVersionError(manifestJson["version"]);
       }
       if (
@@ Expand Down @@