Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tags for Julia 1.0; fix #3 #4

Merged
merged 2 commits into from
Jul 30, 2019

Conversation

janEbert
Copy link
Contributor

Add support for arbitrarily many macros before functions.
Add variables defined on the start of a line (also has macro support).
Add support for type parameterized inline function, that is
f(x::T) where {T} = [...].

Remove dollar symbols; I don't know their meaning as I haven't used
Julia before 1.0.
Remove typealias keyword; does not exist in Julia 1.0.

Problems:

  • Still could use cleanup to not assign the 'function' kind to
    structs, for example.
  • If any matched identifier is between strings or comments, it will
    not be ignored.
  • Lambda functions are added as variables.
  • Functions in the non-global scope are also added. May be desired.

Add support for arbitrarily many macros before functions.
Add variables defined on the start of a line (also has macro support).
Add support for type parameterized inline function, that is
`f(x::T) where {T} = [...]`.
Remove dollar symbols; I don't know their meaning as I haven't used
Julia before 1.0.
Remove `typealias` keyword; does not exist in Julia 1.0.

Problems:
   - Still could use cleanup to not assign the 'function' kind to
     `struct`s, for example.
   - If any matched identifier is between strings or comments, it will
     _not_ be ignored.
   - Lambda functions are added as variables.
   - Functions in the non-global scope are also added. May be desired.
@StefanKarpinski StefanKarpinski requested a review from oxinabox July 29, 2019 15:31
@janEbert janEbert mentioned this pull request Jul 29, 2019
@oxinabox
Copy link
Member

I am going to merge this now, and #5 can be rebased ontop of it.

@oxinabox oxinabox merged commit a6398b5 into JuliaEditorSupport:master Jul 30, 2019
@janEbert
Copy link
Contributor Author

Thanks!

@oxinabox
Copy link
Member

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants