Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define is(read|writ)able for BufferStream. #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fredrikekre
Copy link
Member

No description provided.

@fredrikekre
Copy link
Member Author

CI on travis was stalled so switched to GH actions but that doesn't run since this PR is from a branch

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #6 (5a5ed82) into master (e592419) will increase coverage by 1.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   95.55%   96.73%   +1.18%     
==========================================
  Files           2        2              
  Lines          90       92       +2     
==========================================
+ Hits           86       89       +3     
+ Misses          4        3       -1     
Impacted Files Coverage Δ
src/BufferStream.jl 96.70% <100.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e592419...874ccf7. Read the comment docs.

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems plausible to me, but of course the CI tests are still useless right now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants