Skip to content

Commit

Permalink
Better warning when a patch changes Julia compat (#138)
Browse files Browse the repository at this point in the history
Co-authored-by: Anshul Singhvi <[email protected]>
  • Loading branch information
DilumAluthge and asinghvi17 authored Dec 8, 2019
1 parent e689fb4 commit 1ef05bb
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "RegistryCI"
uuid = "0c95cc5f-2f7e-43fe-82dd-79dbcba86b32"
authors = ["Dilum Aluthge <[email protected]>", "Fredrik Ekre <[email protected]>"]
version = "0.4.2"
version = "0.4.3"

[deps]
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Expand Down
9 changes: 8 additions & 1 deletion src/AutoMerge/guidelines.jl
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,14 @@ function meets_patch_release_does_not_narrow_julia_compat(pkg::String,
if meets_this_guideline
return true, ""
else
return false, "A patch release is not allowed to narrow the supported range of Julia versions"
msg = string("A patch release is not allowed to narrow the ",
"supported ranges of Julia versions. ",
"The ranges have changed from ",
"$(julia_compats_for_old_version) ",
"(in $(old_version)) ",
"to $(julia_compats_for_new_version) ",
"(in $(new_version)).")
return false, msg
end
end

Expand Down

2 comments on commit 1ef05bb

@DilumAluthge
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register branch=master

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/6388

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:

git tag -a v0.4.3 -m "<description of version>" 1ef05bb562e2aa2b1abe5b7f2ee5c00ce2621920
git push origin v0.4.3

Please sign in to comment.