DetailCell: Add variant stories #2407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Size Change: 0 B Total Size: 96.3 kB ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-aparswzouv.chromatic.com/ Chromatic results:
|
beaesguerra
commented
Dec 19, 2024
| @@ -94,7 +94,7 @@ const DetailCell = function (props: DetailCellProps): React.ReactElement { | |||
|
|
|||
| const styles = StyleSheet.create({ | |||
| subtitle: { | |||
| color: color.offBlack64, | |||
| color: "#6D6F74", | |||
There was a problem hiding this comment.
Hardcoding for now based on the thread in WB-1797. It still has a11y color warnings so will get feedback!
beaesguerra
changed the title
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: NOT Published🤕 Oh noes!! We couldn't find any changesets in this PR (8ceaf62). As a result, we did not publish an npm snapshot for you. |
marcysutton
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add scenario and variant stories for DetailCell. This will help us confirm styling for different states with visual regression tests.
For now, the color contrast issues haven't been addressed yet. Coordinating with design on what styling updates we want long term (see WB-1797 comments for more details!). Including these stories for now so we can have visual regression tests ready when we address the color issues!
Issue: WB-1797
Test plan:
?path=/docs/packages-cell-detailcell-all-variants--docs)?path=/story/packages-cell-detailcell--scenarios)