Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable aphrodite-add-style-variable-name rule in eslint-plugin-khan demo project #1095

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Enable aphrodite-add-style-variable-name rule in eslint-plugin-khan demo project #1095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3202d02
update demo package's eslint plugin version to latest release
beaesguerra Dec 13, 2024
75bfdfa
enable aphrodite add style rule in demo project
beaesguerra Dec 13, 2024
56e4106
add changeset
beaesguerra Dec 13, 2024
e4bc789
update to latest version
beaesguerra Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/plenty-bats-flow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
3 changes: 1 addition & 2 deletions packages/eslint-plugin-khan/demo/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module.exports = {

Check warning on line 1 in packages/eslint-plugin-khan/demo/.eslintrc.js

View workflow job for this annotation

GitHub Actions / Lint, typecheck, and coverage check (ubuntu-latest, 20.x) 

File ignored by default.
root: true,
plugins: ["@khanacademy"],
parser: "@typescript-eslint/parser",
Expand All @@ -23,7 +23,6 @@
rootDir: __dirname,
},
],
// TODO(kevinb): re-enable after publishing @khanacademy/eslint-plugin
// "@khanacademy/aphrodite-add-style-variable-name": "error",
"@khanacademy/aphrodite-add-style-variable-name": "error",
},
};
2 changes: 1 addition & 1 deletion packages/eslint-plugin-khan/demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"lint": "eslint --ext .ts --ext .js --ext .tsx --ext .jsx ."
},
"devDependencies": {
"@khanacademy/eslint-plugin": "^3.0.1",
"@khanacademy/eslint-plugin": "^3.1.1",
"eslint": "^8.55.0",
"typescript": "^5.0.4"
},
Expand Down
6 changes: 4 additions & 2 deletions packages/eslint-plugin-khan/demo/yarn.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading