sync: Fix creating dynamic rendering attachments in sync val #9093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 333005. |
|
CI Vulkan-ValidationLayers build # 18454 running. |
|
CI Vulkan-ValidationLayers build # 18454 passed. |
| @@ -976,9 +976,11 @@ syncval_state::DynamicRenderingInfo::Attachment::Attachment(const SyncValidator | |||
| if (view) { | |||
| if (type == AttachmentType::kColor) { | |||
| view_gen = view->MakeImageRangeGen(offset, extent); | |||
| } else if (type == AttachmentType::kDepth) { | |||
| } else if (type == AttachmentType::kDepth && | |||
There was a problem hiding this comment.
Is it a core validation error when depth attachment does not have depth aspect (and similar for stencil)?
If this above check is to skip situation that is not valid in core checks, that one option to consider not to create DynamicRenderingInfo::Attachment objects at all, if that's something that works with current design.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncval would assert if dynamic rendering contains a depth attachment without depth aspect or stencil attachment without stencil aspect