Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve auto push_constants upgrading. #3797

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

mbechard
Copy link
Contributor

Ensure all copies of the global uniform block symbol get updated with the correct layoutPacking when it's auto upgraded to a push_constant. In some cases there are multiple copies, and only one was getting changed previously.

Ensure all copies of the global uniform block symbol get updated with the correct
layoutPacking when it's auto upgraded to a push_constant.
In some cases there are multiple copies, and only one was getting changed previously.
@arcady-lunarg
Copy link
Contributor

Would it make sense to add a unit test for this? In what case was the problem being triggered?

@mbechard
Copy link
Contributor Author

I've only see it occur in one huge shader. It's from an end-user so I don't think they'd want it posted to the repository. I'm not sure under what circumstances the tree ends up with duplicated symbols, but this fix follows other similar workflows at least.
I also don't think the testing infrastructure is setup to test this kind of stuff anyways. We'd need a way to apply different rules to different test cases I think.

Copy link
Contributor

@arcady-lunarg arcady-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@arcady-lunarg arcady-lunarg added the kokoro:run Trigger Google bot runs label Nov 25, 2024
@kokoro-team kokoro-team removed the kokoro:run Trigger Google bot runs label Nov 25, 2024
@arcady-lunarg arcady-lunarg merged commit ff8fafe into KhronosGroup:main Nov 25, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants