[Breaking Change] Fully abandon the already deprecated internalize 🫂 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabacitu
reviewed
Jul 31, 2023
Comment on lines
7
to
11
| case LOADED = 'Already loaded'; | ||
| case IN_CACHE = 'Already in cache'; | ||
| case INTERNALIZED = 'Internalized'; | ||
| case CACHED = 'Cached'; | ||
| case INVALID = 'Not in a CDN or local filesystem, falling back to provided path'; | ||
| case DISABLED = 'Development mode active'; |
There was a problem hiding this comment.
Changing the enum is a BREAKING CHANGE. I vaguely remember using this somewhere... In backpack maybe? Idk. But it was like... if the response from basset is IN_CACHE then echo whatever.
If we change the enum... that response will change...
So it's a breaking change.
There was a problem hiding this comment.
Oooh, that's right 👌
Delaying to next version 👌
tabacitu
requested changes
Jul 31, 2023
promatik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated internalize command and its references.
Can we do it?