Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

power: restartAfterPowerFailure option is carried out conditionally #1241

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gnammix
Copy link

@gnammix gnammix commented Dec 27, 2024

This should fix the issue reported in #1236

Changed the generated activation script fragment to check if the option is actually supported by the machine.
Also added to the option description info that the option could not work on some devices.

…cript only if supported

Minor documentation change
Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add update the checks to fail activation if a user enables this on a machine that doesn’t support it?

@gnammix
Copy link
Author

gnammix commented Dec 29, 2024

Can you add update the checks to fail activation if a user enables this on a machine that doesn’t support it?

Done, I didn't knew about checks.nix :)
I'm only not sure about the use of sudo in the script.

modules/system/checks.nix Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants