defaults: add screencapture.target option #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipkania
changed the title
|
Can you update the tests? |
|
sure! |
filipkania
force-pushed
the
screencapture-target
branch
from
f30afa5 to
19bc0d6
Compare
Enzime
requested changes
Dec 29, 2024
| @@ -48,5 +48,20 @@ with lib; | |||
| Show thumbnail after screencapture before writing to file. The default is true. | |||
| ''; | |||
| }; | |||
|
|
|||
| system.defaults.screencapture.target = mkOption { | |||
| type = types.nullOr types.str; | |||
There was a problem hiding this comment.
Suggested change
| type = types.nullOr types.str; | |
| type = types.nullOr (types.enum [ "file" "clipboard" ... ]); |
Enzime
reviewed
Dec 29, 2024
Enzime
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to set
com.apple.screencapture.targetdefault, which tells screencapture to output screenshot to e.g. clipboard. I prefer to put my screenshots directly into my clipboard, and there wasn't an option to do that through nix-darwin, so i've made the PR :)Tested it using different valid values on Sequoia, valid values were observed by setting different "Save to" settings and reading using
defaults read com.apple.screencapture target: