Major Highway Builder fixes and improvements. #4999
Draft
+1,026
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
A large amount of changes, fixes and improvements to the module. Unironically more than I can remember off the top of my head, but check below for the highlights. This pr is a draft for now because there are still kinks I need to iron out, and much more testing needs to be done. Hopefully people will be able to look over this with fresh eyes and give feedback. The settings are getting a little out of control, I would like to hear feedback on their layout also.
As with previous changes to this module, they are not particularly designed for strict servers. Furthermore, the rigid nature of the module makes it challenging to account for edge cases, so there are likely to be many issues regarding them present. Please notify if you find one, and include a setup to reproduce it if possible - that will make it much easier to be fixed.
Related issues
closes #4644
closes #4621
closes #4380
closes #3159
closes #3078
closes #1908
How Has This Been Tested?
I will likely attach more media of added features, but here are some of the main ones.
Automatically defusing crystal traps:
java_uCaMutgU0Y.mp4
Restocking from shulkers in your inventory:
java_EdnXouE9kW.mp4
Restocking items from your enderchest:
java_I03Hs3YhHd.mp4
Automatically levelling yourself after falling (I only broke the netherrack, the module placed the blocks and jumped up):
java_ROwRdtODcK.mp4
Checklist: