Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] New sales design #210

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[core] New sales design #210

wants to merge 4 commits into from

Conversation

manolisliolios
Copy link
Collaborator

'

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9a108fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suins-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 0:46am

@manolisliolios manolisliolios changed the base branch from tlee/new-pricing to main November 29, 2024 12:58
@manolisliolios manolisliolios changed the title WIP [core] New sales design / new pricing config Dec 2, 2024
@manolisliolios manolisliolios changed the title [core] New sales design / new pricing config [core] New sales design Dec 2, 2024
@manolisliolios manolisliolios marked this pull request as ready for review December 6, 2024 12:53
manolisliolios
manolisliolios commented Dec 6, 2024
View reviewed changes
packages/suins/sources/sales/payment.move
/// useful for system-level discounts, or user-specific discounts.
///
/// TODO: Consider re-using `RequestData` inside the `Receipt`.
/// TODO: Add settings for max year of renewals / max duration of registration here?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is implemented on #218

0xaslan
0xaslan reviewed Dec 20, 2024
View reviewed changes
packages/suins/sources/sales/pricing_config.move

use sui::vec_map::{Self, VecMap};

// Tries to create a range with more than 2 values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/// instead of //

manolisliolios
manolisliolios commented Dec 20, 2024
View reviewed changes
packages/suins/sources/sales/pricing_config.move
RenewalConfig { config }
}

public fun new_range(range: vector<u64>): Range {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could have a from:u64, to:u64 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xaslan 0xaslan 0xaslan left review comments

@leecchh leecchh leecchh left review comments

@damirka damirka Awaiting requested review from damirka

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manolisliolios @leecchh @0xaslan