Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coupons changes and tests #222

Open
wants to merge 12 commits into
base: ml/new-payments-design
Choose a base branch
from
Open

Coupons changes and tests #222

wants to merge 12 commits into from

Conversation

leecchh
Copy link
Contributor

@leecchh leecchh commented Dec 2, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2d2c50a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suins-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 3:44pm

manolisliolios
manolisliolios approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@manolisliolios manolisliolios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM.

Let's wait a bit before landing this to have the core changes reviewed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manolisliolios manolisliolios manolisliolios approved these changes

@damirka damirka Awaiting requested review from damirka

@0xaslan 0xaslan Awaiting requested review from 0xaslan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leecchh @manolisliolios