fix: cleanup for resize event listener and handle Navbar warn #873
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
fix: cleanup for resize event listener and Navbar warn
Which issue(s) this PR fixes:
Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note:
MR Summary:
The summary is added by @codegpt.
This Merge Request focuses on bug fixes related to the project's frontend, specifically within the navbar component. The key updates include:
MenuItems.vue
by importingonUnmounted
from Vue to ensure proper cleanup of the resize event listener. This prevents potential memory leaks by removing the event listener when the component is unmounted.Navbar.vue
to include a newstarChainUrl
prop, allowing for dynamic URL handling within the navbar, enhancing its configurability and functionality.Overall, the MR addresses cleanup and warning issues in the navbar, improving code quality and component flexibility.