Add axis specific last win SOCD cleaning #1119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add axis specific last win SOCD cleaning * Fix formatting
nevius
commented
Aug 18, 2024
| @@ -86,7 +86,7 @@ export const tiltScheme = { | |||
| tiltSOCDMode: yup | |||
| .number() | |||
| .label('Tilt SOCE Mode') | |||
| .validateSelectionWhenValue('TiltInputEnabled', SOCD_MODES), | |||
| .validateSelectionWhenValue('TiltInputEnabled', TILT_SOCD_MODES), | |||
There was a problem hiding this comment.
This looked wrong to me, so I changed it.
nevius
commented
Aug 18, 2024
| case SOCD_MODE_UP_PRIORITY: statusBar += " SOCD-U"; break; | ||
| case SOCD_MODE_SECOND_INPUT_PRIORITY: statusBar += " SOCD-L"; break; | ||
| case SOCD_MODE_FIRST_INPUT_PRIORITY: statusBar += " SOCD-F"; break; | ||
| case SOCD_MODE_BYPASS: statusBar += " SOCD-O"; break; |
There was a problem hiding this comment.
I changed this to SOCD-O (for Off) because I wanted to use SOCD-X for the new one. Not sure if that's OK.
|
For this one, we've been talking internally a bit and it might make more sense to have a per axis SOCD rather than the one-off combinational solutions. I see exactly what you're going for, but I think we're still deciding on how to go forward on this one. Thanks for the PR!! |
|
@arntsonl Thank you. Let me know if I can be of assistance. |
|
@nevius if you need JP translation, ping me via discord. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a feature my Punk Workshop Leverless had before I changed the PCB to a RP2040.
I think it's quite useful for certain games. For example in Street Fighter doing fast dive kicks with Cammy, I would often miss the DOWN input on the QCB, because my thumb as still on UP. With Y-Axis Last Win, the problem can be solved while still allowing for SOCD dashing on the X-Axis.
Is this something you would be willing to include in the main branch?
TODO